Re: [Qemu-devel] [PATCH v2 8/9] blkdebug: Add ability to override unmap geometries

2016-11-21 Thread Eric Blake
On 11/21/2016 03:11 PM, Eric Blake wrote: >>> @@ -398,6 +429,53 @@ static int blkdebug_open(BlockDriverState *bs, QDict >>> *options, int flags, >>> ret = -EINVAL; >>> goto fail_unref; >>> } >>> +max_transfer = qemu_opt_get_size(opts, "max-transfer", 0); >>> +if (ma

Re: [Qemu-devel] [PATCH v2 8/9] blkdebug: Add ability to override unmap geometries

2016-11-21 Thread Eric Blake
On 11/17/2016 05:02 PM, Max Reitz wrote: > On 17.11.2016 21:14, Eric Blake wrote: >> Make it easier to simulate the Dell Equallogic iSCSI with its > > Somehow I feel bad putting company and product names into commit messages... Not the first time I've done it - see commit b8d0a980. Keeping it in

Re: [Qemu-devel] [PATCH v2 8/9] blkdebug: Add ability to override unmap geometries

2016-11-17 Thread Max Reitz
On 17.11.2016 21:14, Eric Blake wrote: > Make it easier to simulate the Dell Equallogic iSCSI with its Somehow I feel bad putting company and product names into commit messages... > unusual 15M preferred and maximum unmap and write zero sizing, > or to simulate Linux loopback block devices enforc

[Qemu-devel] [PATCH v2 8/9] blkdebug: Add ability to override unmap geometries

2016-11-17 Thread Eric Blake
Make it easier to simulate the Dell Equallogic iSCSI with its unusual 15M preferred and maximum unmap and write zero sizing, or to simulate Linux loopback block devices enforcing a small max_transfer of 64k, by allowing blkdebug to wrap any other device with further restrictions on various alignmen