Re: [Qemu-devel] [PATCH v2 8/8] x86: correctly implement soft reset

2014-05-12 Thread Paolo Bonzini
Il 12/05/2014 09:53, Andreas Färber ha scritto: > Do not do a hard reset for port 92h, keyboard controller, or cf9h soft reset. > These only reset the CPU. > > Reviewed-by: Anthony Liguori > Signed-off-by: Paolo Bonzini Apart from the question of whether cpu_soft_reset() is the right API for t

Re: [Qemu-devel] [PATCH v2 8/8] x86: correctly implement soft reset

2014-05-12 Thread Andreas Färber
Am 02.05.2014 16:33, schrieb Paolo Bonzini: > Do not do a hard reset for port 92h, keyboard controller, or cf9h soft reset. > These only reset the CPU. > > Reviewed-by: Anthony Liguori > Signed-off-by: Paolo Bonzini Apart from the question of whether cpu_soft_reset() is the right API for this:

Re: [Qemu-devel] [PATCH v2 8/8] x86: correctly implement soft reset

2014-05-05 Thread Michael S. Tsirkin
On Fri, May 02, 2014 at 04:33:22PM +0200, Paolo Bonzini wrote: > Do not do a hard reset for port 92h, keyboard controller, or cf9h soft reset. > These only reset the CPU. > > Reviewed-by: Anthony Liguori > Signed-off-by: Paolo Bonzini I note that we allow setting reset type in the same write wi

[Qemu-devel] [PATCH v2 8/8] x86: correctly implement soft reset

2014-05-02 Thread Paolo Bonzini
Do not do a hard reset for port 92h, keyboard controller, or cf9h soft reset. These only reset the CPU. Reviewed-by: Anthony Liguori Signed-off-by: Paolo Bonzini --- hw/i386/pc.c | 3 ++- hw/input/pckbd.c | 5 +++-- hw/isa/lpc_ich9.c | 12 ++-- hw/pci-host/piix.c | 8 ++-