Re: [Qemu-devel] [PATCH v2 7/8] block: core copy-on-read logic

2011-11-23 Thread Zhi Yong Wu
On Wed, Nov 23, 2011 at 5:05 PM, Stefan Hajnoczi wrote: > On Wed, Nov 23, 2011 at 3:42 AM, Zhi Yong Wu wrote: >> On Thu, Nov 17, 2011 at 9:40 PM, Stefan Hajnoczi >> wrote: >>>     tracked_request_begin(&req, bs, sector_num, nb_sectors, false); >>> + >>> +    if (bs->copy_on_read) { >> Why is  tr

Re: [Qemu-devel] [PATCH v2 7/8] block: core copy-on-read logic

2011-11-23 Thread Stefan Hajnoczi
On Wed, Nov 23, 2011 at 3:42 AM, Zhi Yong Wu wrote: > On Thu, Nov 17, 2011 at 9:40 PM, Stefan Hajnoczi > wrote: >>     tracked_request_begin(&req, bs, sector_num, nb_sectors, false); >> + >> +    if (bs->copy_on_read) { > Why is  tracked_request_begin/end() not put inside the brace around > bs->c

Re: [Qemu-devel] [PATCH v2 7/8] block: core copy-on-read logic

2011-11-23 Thread Stefan Hajnoczi
On Wed, Nov 23, 2011 at 8:58 AM, Stefan Hajnoczi wrote: > On Wed, Nov 23, 2011 at 4:42 AM, Zhi Yong Wu wrote: >> On Thu, Nov 17, 2011 at 9:40 PM, Stefan Hajnoczi >> wrote: >>> +    /* Cover entire cluster so no additional backing file I/O is required >>> when >>> +     * allocating cluster in t

Re: [Qemu-devel] [PATCH v2 7/8] block: core copy-on-read logic

2011-11-23 Thread Stefan Hajnoczi
On Wed, Nov 23, 2011 at 4:42 AM, Zhi Yong Wu wrote: > On Thu, Nov 17, 2011 at 9:40 PM, Stefan Hajnoczi > wrote: >> +    /* Cover entire cluster so no additional backing file I/O is required >> when >> +     * allocating cluster in the image file. >> +     */ >> +    round_to_clusters(bs, sector_

Re: [Qemu-devel] [PATCH v2 7/8] block: core copy-on-read logic

2011-11-22 Thread Zhi Yong Wu
On Thu, Nov 17, 2011 at 9:40 PM, Stefan Hajnoczi wrote: > Signed-off-by: Stefan Hajnoczi > --- >  block.c      |   72 > ++ >  trace-events |    1 + >  2 files changed, 73 insertions(+), 0 deletions(-) > > diff --git a/block.c b/block.c > in

Re: [Qemu-devel] [PATCH v2 7/8] block: core copy-on-read logic

2011-11-22 Thread Zhi Yong Wu
On Thu, Nov 17, 2011 at 9:40 PM, Stefan Hajnoczi wrote: > Signed-off-by: Stefan Hajnoczi > --- >  block.c      |   72 > ++ >  trace-events |    1 + >  2 files changed, 73 insertions(+), 0 deletions(-) > > diff --git a/block.c b/block.c > in

[Qemu-devel] [PATCH v2 7/8] block: core copy-on-read logic

2011-11-17 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- block.c | 72 ++ trace-events |1 + 2 files changed, 73 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 0eef122..d5faa6c 100644 --- a/block.c +++ b/block.c @@ -1464,6 +1464,61