28.08.2019. 02.07, "Richard Henderson" је
написао/ла:
>
> On 8/27/19 2:34 AM, Peter Maydell wrote:
> >> +tcg_gen_andi_i32(tmp, tmp, -4);
> >
> > Minor nit, but can we use 0xfffc like the old code did,
> > to avoid the reader having to do 2s-complement arithmetic
> > in their head to figure
On Wed, 28 Aug 2019 at 01:07, Richard Henderson
wrote:
>
> On 8/27/19 2:34 AM, Peter Maydell wrote:
> >> +tcg_gen_andi_i32(tmp, tmp, -4);
> >
> > Minor nit, but can we use 0xfffc like the old code did,
> > to avoid the reader having to do 2s-complement arithmetic
> > in their head to figur
On 8/27/19 2:34 AM, Peter Maydell wrote:
>> +tcg_gen_andi_i32(tmp, tmp, -4);
>
> Minor nit, but can we use 0xfffc like the old code did,
> to avoid the reader having to do 2s-complement arithmetic
> in their head to figure out that we're clearing the low 2 bits?
I always preferred "x & -c
On Mon, 19 Aug 2019 at 22:39, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/translate.c | 89 +++---
> target/arm/t16.decode | 3 ++
> 2 files changed, 43 insertions(+), 49 deletions(-)
> +static bool trans_BLX_suffix(Disa
Signed-off-by: Richard Henderson
---
target/arm/translate.c | 89 +++---
target/arm/t16.decode | 3 ++
2 files changed, 43 insertions(+), 49 deletions(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index 51b14d409f..f8997a8424 100644
--- a/t
