Re: [Qemu-devel] [PATCH v2 6/8] block: Handle bs->options in bdrv_open() only

2014-02-10 Thread Benoît Canet
Le Saturday 08 Feb 2014 à 18:39:17 (+0100), Max Reitz a écrit : > The fail paths of bdrv_file_open() and bdrv_open() naturally exhibit > similarities, thus it is possible to reuse the one from bdrv_open() and > shorten the one in bdrv_file_open() accordingly. > > Also, setting bs->options in bdrv_

Re: [Qemu-devel] [PATCH v2 6/8] block: Handle bs->options in bdrv_open() only

2014-02-10 Thread Benoît Canet
Le Saturday 08 Feb 2014 à 18:39:17 (+0100), Max Reitz a écrit : > The fail paths of bdrv_file_open() and bdrv_open() naturally exhibit > similarities, thus it is possible to reuse the one from bdrv_open() and > shorten the one in bdrv_file_open() accordingly. > > Also, setting bs->options in bdrv_

[Qemu-devel] [PATCH v2 6/8] block: Handle bs->options in bdrv_open() only

2014-02-08 Thread Max Reitz
The fail paths of bdrv_file_open() and bdrv_open() naturally exhibit similarities, thus it is possible to reuse the one from bdrv_open() and shorten the one in bdrv_file_open() accordingly. Also, setting bs->options in bdrv_file_open() is not necessary if it is already done in bdrv_open(). Signed