Re: [Qemu-devel] [PATCH v2 5/6] qemu-iotests: Test setting WCE with qdev

2016-07-06 Thread Kevin Wolf
Am 02.07.2016 um 18:15 hat Max Reitz geschrieben: > On 30.06.2016 16:13, Kevin Wolf wrote: > > +if [ "$QEMU_DEFAULT_MACHINE" != "pc" ]; then > > +_notrun "Test uses IDE devices" > > Why not just use virtio? Hm, and I guess use virtio-blk rather than virtio-blk-pci so that it works on all plat

Re: [Qemu-devel] [PATCH v2 5/6] qemu-iotests: Test setting WCE with qdev

2016-07-05 Thread Eric Blake
On 07/05/2016 08:57 AM, Max Reitz wrote: >> I'm not sure yet what the conclusion is. Change query-block to include >> anonymous BBs that are owned by devices? A new query command? Add the >> information to info qtree and whatever the QMP version of it is (if it >> even exists)? > > Well, since yo

Re: [Qemu-devel] [PATCH v2 5/6] qemu-iotests: Test setting WCE with qdev

2016-07-05 Thread Max Reitz
On 04.07.2016 12:50, Kevin Wolf wrote: > Am 02.07.2016 um 18:15 hat Max Reitz geschrieben: >> On 30.06.2016 16:13, Kevin Wolf wrote: >>> +echo "info block" \ >>> +| run_qemu -drive "$drive,cache=$cache" \ >>> + -device "ide-hd,drive=none0$wce" \ >>> +

Re: [Qemu-devel] [PATCH v2 5/6] qemu-iotests: Test setting WCE with qdev

2016-07-04 Thread Kevin Wolf
Am 02.07.2016 um 18:15 hat Max Reitz geschrieben: > On 30.06.2016 16:13, Kevin Wolf wrote: > > +echo "info block" \ > > +| run_qemu -drive "$drive,cache=$cache" \ > > + -device "ide-hd,drive=none0$wce" \ > > +| grep -e "Testing" -e "Cache mode"

Re: [Qemu-devel] [PATCH v2 5/6] qemu-iotests: Test setting WCE with qdev

2016-07-02 Thread Max Reitz
On 30.06.2016 16:13, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/157 | 92 > ++ > tests/qemu-iotests/157.out | 22 +++ > tests/qemu-iotests/group | 1 + > 3 files changed, 115 insertions(+) > create mode 100

[Qemu-devel] [PATCH v2 5/6] qemu-iotests: Test setting WCE with qdev

2016-06-30 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qemu-iotests/157 | 92 ++ tests/qemu-iotests/157.out | 22 +++ tests/qemu-iotests/group | 1 + 3 files changed, 115 insertions(+) create mode 100755 tests/qemu-iotests/157 create mode 100644 tests/qem