Re: [Qemu-devel] [PATCH v2 5/6] msix: Allow full specification of MSIX layout

2012-06-14 Thread Alex Williamson
On Thu, 2012-06-14 at 11:10 +0300, Michael S. Tsirkin wrote: > On Wed, Jun 13, 2012 at 10:51:56PM -0600, Alex Williamson wrote: > > Finally, complete the fully specified interface. msix_add_config() > > gets moved to be closer to the setup functions where it's actually > > used. msix_mmio_setup()

Re: [Qemu-devel] [PATCH v2 5/6] msix: Allow full specification of MSIX layout

2012-06-14 Thread Alex Williamson
On Thu, 2012-06-14 at 08:17 +0200, Jan Kiszka wrote: > On 2012-06-14 06:51, Alex Williamson wrote: > > > -/* Initialize the MSI-X structures. Note: if MSI-X is supported, BAR size > > is > > - * modified, it should be retrieved with msix_bar_size. */ > > +/* Add MSI-X capability to the config s

Re: [Qemu-devel] [PATCH v2 5/6] msix: Allow full specification of MSIX layout

2012-06-14 Thread Michael S. Tsirkin
On Thu, Jun 14, 2012 at 08:17:22AM +0200, Jan Kiszka wrote: > On 2012-06-14 06:51, Alex Williamson wrote: > > Finally, complete the fully specified interface. msix_add_config() > > gets moved to be closer to the setup functions where it's actually > > used. msix_mmio_setup() gets folded into msix

Re: [Qemu-devel] [PATCH v2 5/6] msix: Allow full specification of MSIX layout

2012-06-14 Thread Michael S. Tsirkin
On Wed, Jun 13, 2012 at 10:51:56PM -0600, Alex Williamson wrote: > Finally, complete the fully specified interface. msix_add_config() > gets moved to be closer to the setup functions where it's actually > used. msix_mmio_setup() gets folded into msix_init(). And > msix_uninit() gets reworked a b

Re: [Qemu-devel] [PATCH v2 5/6] msix: Allow full specification of MSIX layout

2012-06-13 Thread Jan Kiszka
On 2012-06-14 06:51, Alex Williamson wrote: > Finally, complete the fully specified interface. msix_add_config() > gets moved to be closer to the setup functions where it's actually > used. msix_mmio_setup() gets folded into msix_init(). And > msix_uninit() gets reworked a bit so we can call it

[Qemu-devel] [PATCH v2 5/6] msix: Allow full specification of MSIX layout

2012-06-13 Thread Alex Williamson
Finally, complete the fully specified interface. msix_add_config() gets moved to be closer to the setup functions where it's actually used. msix_mmio_setup() gets folded into msix_init(). And msix_uninit() gets reworked a bit so we can call it as cleanup from msix_init(). Signed-off-by: Alex Wi