Re: [Qemu-devel] [PATCH v2 5/6] bochs-display: add pcie support

2018-05-22 Thread Gerd Hoffmann
Hi, > > +if (pci_bus_is_express(pci_get_bus(dev))) { > > +dev->cap_present |= QEMU_PCI_CAP_EXPRESS; > > +ret = pcie_endpoint_cap_init(dev, 0x80); > > +assert(ret > 0); > > Maybe error_setg(errp, ...) && return? No. It really should not trigger, and if it does it is

Re: [Qemu-devel] [PATCH v2 5/6] bochs-display: add pcie support

2018-05-22 Thread Philippe Mathieu-Daudé
Hi Gerd, On 05/22/2018 01:50 PM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > hw/display/bochs-display.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c > index 9607df1c34..c33524b558 100644 > --- a/hw/displ

[Qemu-devel] [PATCH v2 5/6] bochs-display: add pcie support

2018-05-22 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/bochs-display.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c index 9607df1c34..c33524b558 100644 --- a/hw/display/bochs-display.c +++ b/hw/display/bochs-display.c @@ -253,6 +253,7 @@