Re: [Qemu-devel] [PATCH v2 5/5] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-03-23 Thread Gerd Hoffmann
On Fr, 2015-03-20 at 14:01 -0400, Gabriel L. Somlo wrote: > Below is "version 2.5" of the command-line fw_cfg patch only. I'll > send out a v3 of the series once we're mostly happy with this one in > particular. Approach taken looks good to me on a quick scan. cheers, Gerd

Re: [Qemu-devel] [PATCH v2 5/5] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-03-20 Thread Gabriel L. Somlo
On Fri, Mar 20, 2015 at 02:01:25PM -0400, Gabriel L. Somlo wrote: > On Thu, Mar 19, 2015 at 06:38:53PM +0100, Laszlo Ersek wrote: > > H... that's messy, again. fw_cfg is built into the qemu binary only > > if you have CONFIG_SOFTMMU. I guess something like this should work: > > > > #ifdef CONF

Re: [Qemu-devel] [PATCH v2 5/5] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-03-20 Thread Gabriel L. Somlo
On Thu, Mar 19, 2015 at 06:38:53PM +0100, Laszlo Ersek wrote: > On 03/19/15 01:18, Gabriel L. Somlo wrote: > > Allow user supplied files to be inserted into the fw_cfg > > device before starting the guest. Since fw_cfg_add_file() > > already disallows duplicate fw_cfg file names, qemu will > > exit

Re: [Qemu-devel] [PATCH v2 5/5] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-03-19 Thread Laszlo Ersek
On 03/19/15 01:18, Gabriel L. Somlo wrote: > Allow user supplied files to be inserted into the fw_cfg > device before starting the guest. Since fw_cfg_add_file() > already disallows duplicate fw_cfg file names, qemu will > exit with an error message if the user supplies multiple > blobs with the sa

Re: [Qemu-devel] [PATCH v2 5/5] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-03-19 Thread Markus Armbruster
[...] > The one other thing I may not have comprehended was the part about > >> Which reminds me: Going for QemuOpts would be very useful (gives >> -readconfig support), and it would solve the init order issue too. >> Instead of having your custom storage you just let QemuOpts parse and >> store t

[Qemu-devel] [PATCH v2 5/5] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-03-18 Thread Gabriel L. Somlo
Allow user supplied files to be inserted into the fw_cfg device before starting the guest. Since fw_cfg_add_file() already disallows duplicate fw_cfg file names, qemu will exit with an error message if the user supplies multiple blobs with the same fw_cfg file name, or if a blob name collides with