Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-08-18 Thread Philippe Mathieu-Daudé
On 08/18/2017 02:32 AM, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 08/17/2017 02:55 PM, Alistair Francis wrote: On 15/08/2017 09:30, Markus Armbruster wrote: The stupid fix is to repeat libraries until the link succeeds: test-util-obj-y = libqemuutil.a libqemustub.a li

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-08-18 Thread Alistair Francis
On Thu, Aug 17, 2017 at 10:32 PM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 08/17/2017 02:55 PM, Alistair Francis wrote: > On 15/08/2017 09:30, Markus Armbruster wrote: >> The stupid fix is to repeat libraries until the link succeeds: >> >> test-util-o

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-08-17 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 08/17/2017 02:55 PM, Alistair Francis wrote: On 15/08/2017 09:30, Markus Armbruster wrote: > The stupid fix is to repeat libraries until the link succeeds: > > test-util-obj-y = libqemuutil.a libqemustub.a libqemuutil.a > > [...] >

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-08-17 Thread Philippe Mathieu-Daudé
On 08/17/2017 02:55 PM, Alistair Francis wrote: On 15/08/2017 09:30, Markus Armbruster wrote: The stupid fix is to repeat libraries until the link succeeds: test-util-obj-y = libqemuutil.a libqemustub.a libqemuutil.a [...] Sticking '-Wp,-(' and '-Wp,-)' into the command line I get from

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-08-17 Thread Philippe Mathieu-Daudé
On 08/17/2017 02:02 PM, Markus Armbruster wrote: Paolo Bonzini writes: On 15/08/2017 09:30, Markus Armbruster wrote: The stupid fix is to repeat libraries until the link succeeds: test-util-obj-y = libqemuutil.a libqemustub.a libqemuutil.a You may have seen this with -lX11 if you're old

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-08-17 Thread Alistair Francis
On Thu, Aug 17, 2017 at 10:02 AM, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 15/08/2017 09:30, Markus Armbruster wrote: >>> The stupid fix is to repeat libraries until the link succeeds: >>> >>> test-util-obj-y = libqemuutil.a libqemustub.a libqemuutil.a >>> >>> You may have see

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-08-17 Thread Markus Armbruster
Paolo Bonzini writes: > On 15/08/2017 09:30, Markus Armbruster wrote: >> The stupid fix is to repeat libraries until the link succeeds: >> >> test-util-obj-y = libqemuutil.a libqemustub.a libqemuutil.a >> >> You may have seen this with -lX11 if you're old enough. >> >> ld(1) suggests the l

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-08-17 Thread Paolo Bonzini
On 15/08/2017 09:30, Markus Armbruster wrote: > The stupid fix is to repeat libraries until the link succeeds: > > test-util-obj-y = libqemuutil.a libqemustub.a libqemuutil.a > > You may have seen this with -lX11 if you're old enough. > > ld(1) suggests the linker can do it for us: > >

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-08-15 Thread Markus Armbruster
Paolo, there's a Make puzzle for you below. Alistair Francis writes: > On Mon, Aug 14, 2017 at 6:34 AM, Markus Armbruster wrote: >> PATCH 3/5 has the exact same subject. Why are the two separate? > > You are right, that is a mess. > > This one doesn't check for newlines at the end while the ea

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-08-14 Thread Alistair Francis
On Mon, Aug 14, 2017 at 6:34 AM, Markus Armbruster wrote: > PATCH 3/5 has the exact same subject. Why are the two separate? You are right, that is a mess. This one doesn't check for newlines at the end while the earlier one checked for and removed new lines. > > Alistair Francis writes: > >>

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-08-14 Thread Markus Armbruster
PATCH 3/5 has the exact same subject. Why are the two separate? Alistair Francis writes: > Convert any remaining uses of fprintf(stderr, "warning:"... > to use warn_report() instead. This helps standardise on a single > method of printing warnings to the user. > > All of the warnings were chang

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-08-03 Thread Alistair Francis
On Fri, Jul 28, 2017 at 4:57 PM, Philippe Mathieu-Daudé wrote: > Hi Alistair, > > On 07/28/2017 07:16 PM, Alistair Francis wrote: >> >> Convert any remaining uses of fprintf(stderr, "warning:"... >> to use warn_report() instead. This helps standardise on a single >> method of printing warnings to

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-07-28 Thread Philippe Mathieu-Daudé
Hi Alistair, On 07/28/2017 07:16 PM, Alistair Francis wrote: Convert any remaining uses of fprintf(stderr, "warning:"... to use warn_report() instead. This helps standardise on a single method of printing warnings to the user. All of the warnings were changed using this command: find ./* -ty

[Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-07-28 Thread Alistair Francis
Convert any remaining uses of fprintf(stderr, "warning:"... to use warn_report() instead. This helps standardise on a single method of printing warnings to the user. All of the warnings were changed using this command: find ./* -type f -exec sed -i 's|fprintf(.*".*warning[,:] |warn_report("|Ig'