Re: [Qemu-devel] [PATCH v2 4/7] tests: Add unit test for X86CPU code

2014-10-01 Thread Paolo Bonzini
Il 01/10/2014 18:28, Eduardo Habkost ha scritto: >> > tests/x86-stub.c perhaps can be moved to target-i386/test-stubs.c? > I was trying to keep all test code inside tests/. But perhaps all the > target-specific test code (including test-x86-cpu.c) could be moved to > target directories, and we coul

Re: [Qemu-devel] [PATCH v2 4/7] tests: Add unit test for X86CPU code

2014-10-01 Thread Eduardo Habkost
On Wed, Oct 01, 2014 at 12:20:18AM +0200, Paolo Bonzini wrote: > Il 30/09/2014 20:26, Eduardo Habkost ha scritto: > > Reasoning for each object file included in the test binary: > > * qom/cpu.o - for TYPE_CPU. Dependencies: > >* qom/qom-qobject.o > > * qom/qdev.o - for TYPE_DEVICE. Dependenci

Re: [Qemu-devel] [PATCH v2 4/7] tests: Add unit test for X86CPU code

2014-09-30 Thread Paolo Bonzini
Il 30/09/2014 20:26, Eduardo Habkost ha scritto: > Reasoning for each object file included in the test binary: > * qom/cpu.o - for TYPE_CPU. Dependencies: >* qom/qom-qobject.o > * qom/qdev.o - for TYPE_DEVICE. Dependencies: >* qom/container.o >* vmstate.o. Dependencies: > * qemu-

[Qemu-devel] [PATCH v2 4/7] tests: Add unit test for X86CPU code

2014-09-30 Thread Eduardo Habkost
The unit test includes target-i386/cpu.c instead of simply linking against cpu.o because the test code will use static variables/functions from cpu.c. Reasoning for each object file included in the test binary: * qom/cpu.o - for TYPE_CPU. Dependencies: * qom/qom-qobject.o * qom/qdev.o - for T