Re: [Qemu-devel] [PATCH v2 4/5] Convert multi-line fprintf() to warn_report()

2017-08-14 Thread Markus Armbruster
Alistair Francis writes: > On Mon, Aug 14, 2017 at 6:30 AM, Markus Armbruster wrote: [...] >> Drop the periods from the warning messages, and you may add >> Reviewed-by: Markus Armbruster >> >> I encourage you to also use the opportunity to improve line breaks. >> >> I'm not asking you to fix t

Re: [Qemu-devel] [PATCH v2 4/5] Convert multi-line fprintf() to warn_report()

2017-08-14 Thread Philippe Mathieu-Daudé
Hi Alistair, On 07/28/2017 07:16 PM, Alistair Francis wrote: Convert all the multi-line uses of fprintf(stderr, "warning:"..."\n"... to use warn_report() instead. This helps standardise on a single method of printing warnings to the user. All of the warnings were changed using these commands:

Re: [Qemu-devel] [PATCH v2 4/5] Convert multi-line fprintf() to warn_report()

2017-08-14 Thread Alistair Francis
On Mon, Aug 14, 2017 at 6:30 AM, Markus Armbruster wrote: > Alistair Francis writes: > >> Convert all the multi-line uses of fprintf(stderr, "warning:"..."\n"... >> to use warn_report() instead. This helps standardise on a single >> method of printing warnings to the user. >> >> All of the warnin

Re: [Qemu-devel] [PATCH v2 4/5] Convert multi-line fprintf() to warn_report()

2017-08-14 Thread Markus Armbruster
Alistair Francis writes: > Convert all the multi-line uses of fprintf(stderr, "warning:"..."\n"... > to use warn_report() instead. This helps standardise on a single > method of printing warnings to the user. > > All of the warnings were changed using these commands: > find ./* -type f -exec se

[Qemu-devel] [PATCH v2 4/5] Convert multi-line fprintf() to warn_report()

2017-07-28 Thread Alistair Francis
Convert all the multi-line uses of fprintf(stderr, "warning:"..."\n"... to use warn_report() instead. This helps standardise on a single method of printing warnings to the user. All of the warnings were changed using these commands: find ./* -type f -exec sed -i \ 'N; {s|fprintf(.*".*warning