Re: [Qemu-devel] [PATCH v2 4/4] target-i386: Call cpu_exec_init() on realize

2015-09-21 Thread Eduardo Habkost
On Mon, Sep 21, 2015 at 11:11:47AM +0530, Bharata B Rao wrote: > On Sat, Sep 19, 2015 at 1:08 AM, Eduardo Habkost wrote: > > QOM instance_init functions are not supposed to have any side-effects, > > as new objects may be created at any moment for querying property > > information (see qmp_device_

Re: [Qemu-devel] [PATCH v2 4/4] target-i386: Call cpu_exec_init() on realize

2015-09-20 Thread Bharata B Rao
On Sat, Sep 19, 2015 at 1:08 AM, Eduardo Habkost wrote: > QOM instance_init functions are not supposed to have any side-effects, > as new objects may be created at any moment for querying property > information (see qmp_device_list_properties()). > > Calling cpu_exec_init() also affects QEMU's abi

[Qemu-devel] [PATCH v2 4/4] target-i386: Call cpu_exec_init() on realize

2015-09-18 Thread Eduardo Habkost
QOM instance_init functions are not supposed to have any side-effects, as new objects may be created at any moment for querying property information (see qmp_device_list_properties()). Calling cpu_exec_init() also affects QEMU's ability to handle errors during CPU creation, as some actions done by