Re: [Qemu-devel] [PATCH v2 4/4] iotests: fix expected error message

2016-09-21 Thread Marc-André Lureau
- Original Message - > On 09/21/2016 03:10 PM, Marc-André Lureau wrote: > > Missing argument returns a corresponding error message for all types > > now. > > > > The "old" qmp dispatch code didn't return QERR_MISSING_PARAMETER for > > argument structure members (it returned QERR_INVALID_

Re: [Qemu-devel] [PATCH v2 4/4] iotests: fix expected error message

2016-09-21 Thread Eric Blake
On 09/21/2016 03:10 PM, Marc-André Lureau wrote: > Missing argument returns a corresponding error message for all types > now. > > The "old" qmp dispatch code didn't return QERR_MISSING_PARAMETER for > argument structure members (it returned QERR_INVALID_PARAMETER). Only > for top-level argument i

[Qemu-devel] [PATCH v2 4/4] iotests: fix expected error message

2016-09-21 Thread Marc-André Lureau
Missing argument returns a corresponding error message for all types now. The "old" qmp dispatch code didn't return QERR_MISSING_PARAMETER for argument structure members (it returned QERR_INVALID_PARAMETER). Only for top-level argument it did return QERR_MISSING_PARAMETER. It is preferable to have