Re: [Qemu-devel] [PATCH v2 36/40] job: Add lifecycle QMP commands

2018-05-23 Thread John Snow
On 05/18/2018 09:21 AM, Kevin Wolf wrote: > +{ 'command': 'job-complete', 'data': { 'id': 'str' } } Do we have to name it this? I've always disliked how "complete" is used as both a verb and an adjective in our code (hence why I used such bizarre phrasings like "concluded" in my jobs patches) ..

Re: [Qemu-devel] [PATCH v2 36/40] job: Add lifecycle QMP commands

2018-05-22 Thread Kevin Wolf
Am 18.05.2018 um 20:12 hat Eric Blake geschrieben: > On 05/18/2018 08:21 AM, Kevin Wolf wrote: > > This adds QMP commands that control the transition between states of the > > job lifecycle. > > > > Signed-off-by: Kevin Wolf > > --- > > qapi/job.json | 99 ++

Re: [Qemu-devel] [PATCH v2 36/40] job: Add lifecycle QMP commands

2018-05-18 Thread Eric Blake
On 05/18/2018 08:21 AM, Kevin Wolf wrote: This adds QMP commands that control the transition between states of the job lifecycle. Signed-off-by: Kevin Wolf --- qapi/job.json | 99 +++ job-qmp.c | 134 +++

[Qemu-devel] [PATCH v2 36/40] job: Add lifecycle QMP commands

2018-05-18 Thread Kevin Wolf
This adds QMP commands that control the transition between states of the job lifecycle. Signed-off-by: Kevin Wolf --- qapi/job.json | 99 +++ job-qmp.c | 134 ++ MAINTAINERS | 1 + Makefile.o