Re: [Qemu-devel] [PATCH v2 3/7] disas: arm-a64: Make printfer and stream variable

2015-05-24 Thread Peter Crosthwaite
On Mon, May 11, 2015 at 8:57 AM, Richard Henderson wrote: > On 05/09/2015 01:11 PM, Peter Crosthwaite wrote: >> class QEMUDisassembler : public Disassembler { >> public: >> -explicit QEMUDisassembler(FILE *stream) : stream_(stream) { } >> +QEMUDisassembler() { >> +printf_ = NULL;

Re: [Qemu-devel] [PATCH v2 3/7] disas: arm-a64: Make printfer and stream variable

2015-05-11 Thread Richard Henderson
On 05/09/2015 01:11 PM, Peter Crosthwaite wrote: > class QEMUDisassembler : public Disassembler { > public: > -explicit QEMUDisassembler(FILE *stream) : stream_(stream) { } > +QEMUDisassembler() { > +printf_ = NULL; > +stream_ = NULL; > +} As a nit, I would have writt

[Qemu-devel] [PATCH v2 3/7] disas: arm-a64: Make printfer and stream variable

2015-05-09 Thread Peter Crosthwaite
In a normal disassembly flow, the printf and stream being used varies from disas job to job. In particular it varies if mixing monitor_disas and target_disas. Make both the printfer function and target stream settable in the QEMUDisassmbler class. Remove the stream_ initialisation from the constru