Re: [Qemu-devel] [PATCH v2 3/6] scsi: fix parsing of allocation length field

2011-11-18 Thread Paolo Bonzini
On 11/18/2011 02:07 PM, Kevin Wolf wrote: > -cmd->xfer = ldl_be_p(&buf[10]); > +cmd->xfer = ldl_be_p(&buf[10])& 0xULL; Makes me wonder why we don't have an unsigned version of ldl_be_p... Yes, that was on my list for 1.1. Paolo

Re: [Qemu-devel] [PATCH v2 3/6] scsi: fix parsing of allocation length field

2011-11-18 Thread Kevin Wolf
Am 14.11.2011 14:31, schrieb Paolo Bonzini: > - several MMC commands were parsed wrong by QEMU because their allocation > length/parameter list length is placed in a non-standard position in > the CDB (i.e. it is different from most commands with the same value in > bits 5-7). > > - SEND VOLUME TA

[Qemu-devel] [PATCH v2 3/6] scsi: fix parsing of allocation length field

2011-11-14 Thread Paolo Bonzini
- several MMC commands were parsed wrong by QEMU because their allocation length/parameter list length is placed in a non-standard position in the CDB (i.e. it is different from most commands with the same value in bits 5-7). - SEND VOLUME TAG length was multiplied by 40 which is not in SMC. The

[Qemu-devel] [PATCH v2 3/6] scsi: fix parsing of allocation length field

2011-11-14 Thread Paolo Bonzini
- several MMC commands were parsed wrong by QEMU because their allocation length/parameter list length is placed in a non-standard position in the CDB (i.e. it is different from most commands with the same value in bits 5-7). - SEND VOLUME TAG length was multiplied by 40 which is not in SMC. The