Re: [Qemu-devel] [PATCH v2 3/6] json-parser: Fix two coverity defects

2014-06-09 Thread Gonglei (Arei)
> -Original Message- > From: Luiz Capitulino [mailto:lcapitul...@redhat.com] > Sent: Tuesday, June 10, 2014 4:16 AM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; av1...@comtv.ru; kra...@redhat.com; > ler...@redhat.com; qiaonuo...@cn.fujitsu.com; afaer...@suse.de; > ebl...@redhat.com; pb

Re: [Qemu-devel] [PATCH v2 3/6] json-parser: Fix two coverity defects

2014-06-09 Thread Luiz Capitulino
On Wed, 28 May 2014 21:21:37 +0800 wrote: > From: Gonglei > > Pointer "token" returned by "parser_context_pop_token(ctxt)" is never used. That's not true, "token" is used by token_is_operator(). The patch seems correct to me, but you have to fix the changelog. Also, who's going to take care o

Re: [Qemu-devel] [PATCH v2 3/6] json-parser: Fix two coverity defects

2014-05-28 Thread Paolo Bonzini
Il 28/05/2014 15:21, arei.gong...@huawei.com ha scritto: From: Gonglei Pointer "token" returned by "parser_context_pop_token(ctxt)" is never used. Signed-off-by: ChenLiang Signed-off-by: Gonglei --- qobject/json-parser.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-)

[Qemu-devel] [PATCH v2 3/6] json-parser: Fix two coverity defects

2014-05-28 Thread arei.gonglei
From: Gonglei Pointer "token" returned by "parser_context_pop_token(ctxt)" is never used. Signed-off-by: ChenLiang Signed-off-by: Gonglei --- qobject/json-parser.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/qobject/json-parser.c b/qobject/json-parser.