Re: [Qemu-devel] [PATCH v2 3/6] add backup related monitor commands

2012-12-12 Thread Dietmar Maurer
> I'm coming into this review late, so I'm not sure what your series is adding > that cannot already be done with external snapshots and migration to file. This series try to do backup more efficient (see docu in [PATCH v2 1/6]). > But any time someone proposes new QMP commands that libvirt might

Re: [Qemu-devel] [PATCH v2 3/6] add backup related monitor commands

2012-12-12 Thread Eric Blake
On 11/30/2012 02:22 AM, Dietmar Maurer wrote: > We use a generic BackupDriver struct to encaplulated all archive format s/encaplulated/encapsulated/ > related function. > > Another option would be to simply dump to > the output fh (pipe), and an external binary saves the data. That way we > cou

[Qemu-devel] [PATCH v2 3/6] add backup related monitor commands

2012-11-30 Thread Dietmar Maurer
We use a generic BackupDriver struct to encaplulated all archive format related function. Another option would be to simply dump to the output fh (pipe), and an external binary saves the data. That way we could move the whole archive format related code out of qemu. Signed-off-by: Dietmar Maurer