Re: [Qemu-devel] [PATCH v2 3/5] sockets: remove use of QemuOpts from socket_connect

2015-11-18 Thread Daniel P. Berrange
On Tue, Nov 17, 2015 at 03:40:58PM -0700, Eric Blake wrote: > On 11/17/2015 10:00 AM, Daniel P. Berrange wrote: > > The socket_connect method accepts a QAPI SocketAddress object > > which it then turns into QemuOpts before calling the > > inet_connect_opts/unix_connect_opts helper methods. By > > c

Re: [Qemu-devel] [PATCH v2 3/5] sockets: remove use of QemuOpts from socket_connect

2015-11-17 Thread Eric Blake
On 11/17/2015 10:00 AM, Daniel P. Berrange wrote: > The socket_connect method accepts a QAPI SocketAddress object > which it then turns into QemuOpts before calling the > inet_connect_opts/unix_connect_opts helper methods. By > converting the latter to use QAPI SocketAddress directly, > the QemuOpt

[Qemu-devel] [PATCH v2 3/5] sockets: remove use of QemuOpts from socket_connect

2015-11-17 Thread Daniel P. Berrange
The socket_connect method accepts a QAPI SocketAddress object which it then turns into QemuOpts before calling the inet_connect_opts/unix_connect_opts helper methods. By converting the latter to use QAPI SocketAddress directly, the QemuOpts conversion step can be eliminated This also fixes the pro