Re: [Qemu-devel] [PATCH v2 3/4] vfio: vfio-pci device assignment driver

2012-08-14 Thread Jan Kiszka
On 2012-08-14 21:09, Alex Williamson wrote: >>> +static void vfio_map_bar(VFIODevice *vdev, int nr) >>> +{ >>> +VFIOBAR *bar = &vdev->bars[nr]; >>> +unsigned size = bar->size; >>> +char name[64]; >>> +uint32_t pci_bar; >>> +uint8_t type; >>> +int ret; >>> + >>> +/* Skip

Re: [Qemu-devel] [PATCH v2 3/4] vfio: vfio-pci device assignment driver

2012-08-14 Thread Alex Williamson
On Tue, 2012-08-14 at 19:40 +0200, Jan Kiszka wrote: > Just some comments, didn't look at all details. Thanks! I'll send out a v3 soon. I think that the off-by-one in strncat doesn't exist though, so would appreciate if you could double check. Individual comments below... > On 2012-08-02 21:17

Re: [Qemu-devel] [PATCH v2 3/4] vfio: vfio-pci device assignment driver

2012-08-14 Thread Jan Kiszka
Just some comments, didn't look at all details. On 2012-08-02 21:17, Alex Williamson wrote: > + > +static int vfio_msix_vector_use(PCIDevice *pdev, > +unsigned int vector, MSIMessage msg) > +{ > +VFIODevice *vdev = DO_UPCAST(VFIODevice, pdev, pdev); > +int r