Re: [Qemu-devel] [PATCH v2 3/4] net/socket: Convert error report message to Error

2017-05-03 Thread Jason Wang
On 2017年05月03日 16:59, Mao Zhongyi wrote: On 05/03/2017 04:54 PM, Markus Armbruster wrote: Mao Zhongyi writes: Hi, Markus,Daniel On 04/28/2017 04:02 PM, Markus Armbruster wrote: "Daniel P. Berrange" writes: On Thu, Apr 27, 2017 at 06:24:17PM +0200, Markus Armbruster wrote: No review,

Re: [Qemu-devel] [PATCH v2 3/4] net/socket: Convert error report message to Error

2017-05-03 Thread Mao Zhongyi
On 05/03/2017 04:54 PM, Markus Armbruster wrote: Mao Zhongyi writes: Hi, Markus,Daniel On 04/28/2017 04:02 PM, Markus Armbruster wrote: "Daniel P. Berrange" writes: On Thu, Apr 27, 2017 at 06:24:17PM +0200, Markus Armbruster wrote: No review, just an observation. Mao Zhongyi writes:

Re: [Qemu-devel] [PATCH v2 3/4] net/socket: Convert error report message to Error

2017-05-03 Thread Markus Armbruster
Mao Zhongyi writes: > Hi, Markus,Daniel > > On 04/28/2017 04:02 PM, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: >> >>> On Thu, Apr 27, 2017 at 06:24:17PM +0200, Markus Armbruster wrote: No review, just an observation. Mao Zhongyi writes: > Currently, net_soc

Re: [Qemu-devel] [PATCH v2 3/4] net/socket: Convert error report message to Error

2017-05-03 Thread Mao Zhongyi
On 05/03/2017 04:37 PM, Daniel P. Berrange wrote: On Wed, May 03, 2017 at 03:09:57PM +0800, Mao Zhongyi wrote: Hi, Markus,Daniel On 04/28/2017 04:02 PM, Markus Armbruster wrote: "Daniel P. Berrange" writes: On Thu, Apr 27, 2017 at 06:24:17PM +0200, Markus Armbruster wrote: No review, jus

Re: [Qemu-devel] [PATCH v2 3/4] net/socket: Convert error report message to Error

2017-05-03 Thread Daniel P. Berrange
On Wed, May 03, 2017 at 03:09:57PM +0800, Mao Zhongyi wrote: > Hi, Markus,Daniel > > On 04/28/2017 04:02 PM, Markus Armbruster wrote: > > "Daniel P. Berrange" writes: > > > > > On Thu, Apr 27, 2017 at 06:24:17PM +0200, Markus Armbruster wrote: > > > > No review, just an observation. > > > > > >

Re: [Qemu-devel] [PATCH v2 3/4] net/socket: Convert error report message to Error

2017-05-03 Thread Mao Zhongyi
Hi, Markus,Daniel On 04/28/2017 04:02 PM, Markus Armbruster wrote: "Daniel P. Berrange" writes: On Thu, Apr 27, 2017 at 06:24:17PM +0200, Markus Armbruster wrote: No review, just an observation. Mao Zhongyi writes: Currently, net_socket_mcast_create(), net_socket_fd_init_dgram() and net_

Re: [Qemu-devel] [PATCH v2 3/4] net/socket: Convert error report message to Error

2017-04-28 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Thu, Apr 27, 2017 at 06:24:17PM +0200, Markus Armbruster wrote: >> No review, just an observation. >> >> Mao Zhongyi writes: >> >> > Currently, net_socket_mcast_create(), net_socket_fd_init_dgram() and >> > net_socket_fd_init() use the function such as fprintf

Re: [Qemu-devel] [PATCH v2 3/4] net/socket: Convert error report message to Error

2017-04-27 Thread Daniel P. Berrange
On Thu, Apr 27, 2017 at 06:24:17PM +0200, Markus Armbruster wrote: > No review, just an observation. > > Mao Zhongyi writes: > > > Currently, net_socket_mcast_create(), net_socket_fd_init_dgram() and > > net_socket_fd_init() use the function such as fprintf(), perror() to > > report an error mes

Re: [Qemu-devel] [PATCH v2 3/4] net/socket: Convert error report message to Error

2017-04-27 Thread Markus Armbruster
No review, just an observation. Mao Zhongyi writes: > Currently, net_socket_mcast_create(), net_socket_fd_init_dgram() and > net_socket_fd_init() use the function such as fprintf(), perror() to > report an error message. > > Now, convert these functions to Error. > > CC: jasow...@redhat.com, arm

[Qemu-devel] [PATCH v2 3/4] net/socket: Convert error report message to Error

2017-04-26 Thread Mao Zhongyi
Currently, net_socket_mcast_create(), net_socket_fd_init_dgram() and net_socket_fd_init() use the function such as fprintf(), perror() to report an error message. Now, convert these functions to Error. CC: jasow...@redhat.com, arm...@redhat.com Signed-off-by: Mao Zhongyi --- net/socket.c | 66 +