Re: [Qemu-devel] [PATCH v2 3/4] i440fx-test: generate temporary firmware blob

2013-12-02 Thread Markus Armbruster
Laszlo Ersek writes: > On 11/29/13 14:57, Markus Armbruster wrote: >> Laszlo Ersek writes: >> >>> The blob is 64K in size and contains 0x00..0xFF repeatedly. >>> >>> The client code added to main() wouldn't make much sense in the long term. >>> It helps with debugging and it silences gcc about

Re: [Qemu-devel] [PATCH v2 3/4] i440fx-test: generate temporary firmware blob

2013-11-29 Thread Paolo Bonzini
Il 29/11/2013 16:07, Laszlo Ersek ha scritto: > I think that the way I did it here matches this situation well. After > the g_file_open_tmp() call succeeds, we must close fd in any case > (independently of whether as a whole the function succeeds or not). > Optionally, we must also unlink the file,

Re: [Qemu-devel] [PATCH v2 3/4] i440fx-test: generate temporary firmware blob

2013-11-29 Thread Laszlo Ersek
On 11/29/13 14:57, Markus Armbruster wrote: > Laszlo Ersek writes: > >> The blob is 64K in size and contains 0x00..0xFF repeatedly. >> >> The client code added to main() wouldn't make much sense in the long term. >> It helps with debugging and it silences gcc about create_firmware() being >> unus

Re: [Qemu-devel] [PATCH v2 3/4] i440fx-test: generate temporary firmware blob

2013-11-29 Thread Markus Armbruster
Laszlo Ersek writes: > The blob is 64K in size and contains 0x00..0xFF repeatedly. > > The client code added to main() wouldn't make much sense in the long term. > It helps with debugging and it silences gcc about create_firmware() being > unused, and we'll replace it in the next patch anyway. >

[Qemu-devel] [PATCH v2 3/4] i440fx-test: generate temporary firmware blob

2013-11-28 Thread Laszlo Ersek
The blob is 64K in size and contains 0x00..0xFF repeatedly. The client code added to main() wouldn't make much sense in the long term. It helps with debugging and it silences gcc about create_firmware() being unused, and we'll replace it in the next patch anyway. Signed-off-by: Laszlo Ersek ---