Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-17 Thread Lluís
Stefan Hajnoczi writes: > If you don't get around to it I'll do it sometime but I'm short on > time right now. Wanted to let you know in case you're waiting for > more discussion on this thread. Sure, don't worry. I do not have enough time right now either, so I'll tell you if I start to impleme

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-16 Thread Stefan Hajnoczi
On Thu, Nov 11, 2010 at 9:31 AM, Stefan Hajnoczi wrote: > On Wed, Nov 10, 2010 at 9:20 PM, Lluís wrote: >> Blue Swirl writes: >> >>> On Wed, Nov 10, 2010 at 7:57 PM, Lluís wrote: Blue Swirl writes: > On Wed, Nov 10, 2010 at 5:59 PM, Lluís wrote: >> So, my patch is just a matte

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-11 Thread Stefan Hajnoczi
On Wed, Nov 10, 2010 at 9:20 PM, Lluís wrote: > Blue Swirl writes: > >> On Wed, Nov 10, 2010 at 7:57 PM, Lluís wrote: >>> Blue Swirl writes: >>> On Wed, Nov 10, 2010 at 5:59 PM, Lluís wrote: > So, my patch is just a matter of having all events available _only_ when > you use a backe

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-10 Thread Lluís
Blue Swirl writes: > On Wed, Nov 10, 2010 at 7:57 PM, Lluís wrote: >> Blue Swirl writes: >> >>> On Wed, Nov 10, 2010 at 5:59 PM, Lluís wrote: So, my patch is just a matter of having all events available _only_ when you use a backend other than "nop". >> >>> Then the default for simpl

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 7:57 PM, Lluís wrote: > Blue Swirl writes: > >> On Wed, Nov 10, 2010 at 5:59 PM, Lluís wrote: >>> So, my patch is just a matter of having all events available _only_ when >>> you use a backend other than "nop". > >> Then the default for simpletrace (and dtrace?) should als

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-10 Thread Lluís
Blue Swirl writes: > On Wed, Nov 10, 2010 at 5:59 PM, Lluís wrote: >> So, my patch is just a matter of having all events available _only_ when >> you use a backend other than "nop". > Then the default for simpletrace (and dtrace?) should also be disabled > initial state. If you have 1000 tracepo

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 5:59 PM, Lluís wrote: > Blue Swirl writes: > >> On Tue, Nov 9, 2010 at 2:08 PM, Lluís wrote: >>> Enable all trace events by default, assuming their frequency is relatively >>> low, >>> so there will be no measurable performace impact. > >> Even if the impact for one trace

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-10 Thread Lluís
Blue Swirl writes: > On Tue, Nov 9, 2010 at 2:08 PM, Lluís wrote: >> Enable all trace events by default, assuming their frequency is relatively >> low, >> so there will be no measurable performace impact. > Even if the impact for one tracepoint is low, if all tracepoints are > enabled, eventual

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-10 Thread Blue Swirl
On Tue, Nov 9, 2010 at 2:08 PM, Lluís wrote: > Enable all trace events by default, assuming their frequency is relatively > low, > so there will be no measurable performace impact. Even if the impact for one tracepoint is low, if all tracepoints are enabled, eventually (considering that the numb

[Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-09 Thread Lluís
Enable all trace events by default, assuming their frequency is relatively low, so there will be no measurable performace impact. Signed-off-by: Lluís Vilanova --- trace-events | 251 +- 1 files changed, 124 insertions(+), 127 deletions(-)