Re: [Qemu-devel] [PATCH v2 3/3] qemu-io: Correct error messages

2015-10-27 Thread Eric Blake
On 10/27/2015 09:50 AM, John Snow wrote: >>> +default: >>> +printf("Parsing error -- %s\n", arg); >> >> I still think ':' is better than ' --' in error messages, but I'll leave >> it up to the maintainer. >> > > Crud, sorry Eric -- I didn't do this on purpose. As Kevin notes, I was >

Re: [Qemu-devel] [PATCH v2 3/3] qemu-io: Correct error messages

2015-10-27 Thread Kevin Wolf
Am 27.10.2015 um 16:50 hat John Snow geschrieben: > > > On 10/26/2015 10:26 PM, Eric Blake wrote: > > On 10/26/2015 05:45 PM, John Snow wrote: > >> Reported-by: Max Reitz > >> Signed-off-by: John Snow > >> Reviewed-by: Eric Blake > >> --- > >> qemu-io-cmds.c | 53 +

Re: [Qemu-devel] [PATCH v2 3/3] qemu-io: Correct error messages

2015-10-27 Thread John Snow
On 10/26/2015 10:26 PM, Eric Blake wrote: > On 10/26/2015 05:45 PM, John Snow wrote: >> Reported-by: Max Reitz >> Signed-off-by: John Snow >> Reviewed-by: Eric Blake >> --- >> qemu-io-cmds.c | 53 ++--- >> 1 file changed, 34 insertions(+), 19 de

Re: [Qemu-devel] [PATCH v2 3/3] qemu-io: Correct error messages

2015-10-27 Thread Kevin Wolf
Am 27.10.2015 um 03:26 hat Eric Blake geschrieben: > On 10/26/2015 05:45 PM, John Snow wrote: > > Reported-by: Max Reitz > > Signed-off-by: John Snow > > Reviewed-by: Eric Blake > > --- > > qemu-io-cmds.c | 53 ++--- > > 1 file changed, 34 inserti

Re: [Qemu-devel] [PATCH v2 3/3] qemu-io: Correct error messages

2015-10-27 Thread Kevin Wolf
Am 27.10.2015 um 00:45 hat John Snow geschrieben: > Reported-by: Max Reitz > Signed-off-by: John Snow > Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v2 3/3] qemu-io: Correct error messages

2015-10-26 Thread Eric Blake
On 10/26/2015 05:45 PM, John Snow wrote: > Reported-by: Max Reitz > Signed-off-by: John Snow > Reviewed-by: Eric Blake > --- > qemu-io-cmds.c | 53 ++--- > 1 file changed, 34 insertions(+), 19 deletions(-) > > diff --git a/qemu-io-cmds.c b/qemu-i

[Qemu-devel] [PATCH v2 3/3] qemu-io: Correct error messages

2015-10-26 Thread John Snow
Reported-by: Max Reitz Signed-off-by: John Snow Reviewed-by: Eric Blake --- qemu-io-cmds.c | 53 ++--- 1 file changed, 34 insertions(+), 19 deletions(-) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index 44d24e8..92c6b87 100644 --- a/qemu-io-cmds