Re: [Qemu-devel] [PATCH v2 3/3] migration: add bitmap for received page

2017-06-16 Thread Alexey Perevalov
On 06/16/2017 09:46 PM, Dr. David Alan Gilbert wrote: * Alexey Perevalov (a.pereva...@samsung.com) wrote: On 06/16/2017 08:14 PM, Dr. David Alan Gilbert wrote: * Alexey Perevalov (a.pereva...@samsung.com) wrote: This patch adds ability to track down already received pages, it's necessary for c

Re: [Qemu-devel] [PATCH v2 3/3] migration: add bitmap for received page

2017-06-16 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > On 06/16/2017 08:14 PM, Dr. David Alan Gilbert wrote: > > * Alexey Perevalov (a.pereva...@samsung.com) wrote: > > > This patch adds ability to track down already received > > > pages, it's necessary for calculation vCPU block time in > > > postc

Re: [Qemu-devel] [PATCH v2 3/3] migration: add bitmap for received page

2017-06-16 Thread Alexey Perevalov
On 06/16/2017 08:14 PM, Dr. David Alan Gilbert wrote: * Alexey Perevalov (a.pereva...@samsung.com) wrote: This patch adds ability to track down already received pages, it's necessary for calculation vCPU block time in postcopy migration feature, maybe for restore after postcopy migration failure

Re: [Qemu-devel] [PATCH v2 3/3] migration: add bitmap for received page

2017-06-16 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > On 06/16/2017 12:06 PM, Peter Xu wrote: > > On Thu, Jun 15, 2017 at 07:36:15PM +0300, Alexey Perevalov wrote: > > > > [...] > > > > > +void init_receivedmap(void) > > > +{ > > > +RAMBlock *rb; > > > + > > > +RAMBLOCK_FOREACH(rb) { > >

Re: [Qemu-devel] [PATCH v2 3/3] migration: add bitmap for received page

2017-06-16 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > This patch adds ability to track down already received > pages, it's necessary for calculation vCPU block time in > postcopy migration feature, maybe for restore after > postcopy migration failure. > Also it's necessary to solve shared memory is

Re: [Qemu-devel] [PATCH v2 3/3] migration: add bitmap for received page

2017-06-16 Thread Alexey Perevalov
On 06/16/2017 12:06 PM, Peter Xu wrote: On Thu, Jun 15, 2017 at 07:36:15PM +0300, Alexey Perevalov wrote: [...] +void init_receivedmap(void) +{ +RAMBlock *rb; + +RAMBLOCK_FOREACH(rb) { +unsigned long pages; +pages = rb->max_length >> TARGET_PAGE_BITS; Nit: I would asse

Re: [Qemu-devel] [PATCH v2 3/3] migration: add bitmap for received page

2017-06-16 Thread Peter Xu
On Thu, Jun 15, 2017 at 07:36:15PM +0300, Alexey Perevalov wrote: [...] > +void init_receivedmap(void) > +{ > +RAMBlock *rb; > + > +RAMBLOCK_FOREACH(rb) { > +unsigned long pages; > +pages = rb->max_length >> TARGET_PAGE_BITS; Nit: I would assert(!rb->receivedmap) before n

[Qemu-devel] [PATCH v2 3/3] migration: add bitmap for received page

2017-06-15 Thread Alexey Perevalov
This patch adds ability to track down already received pages, it's necessary for calculation vCPU block time in postcopy migration feature, maybe for restore after postcopy migration failure. Also it's necessary to solve shared memory issue in postcopy livemigration. Information about received page