Re: [Qemu-devel] [PATCH v2 3/3] edu: uses uint64_t in dma operation

2019-04-22 Thread Philippe Mathieu-Daudé
On 4/22/19 3:21 AM, Li Qiang wrote: > > > Philippe Mathieu-Daudé mailto:phi...@redhat.com>> 于 > 2019年4月21日周日 下午6:32写道: > > On 4/20/19 6:14 PM, Li Qiang wrote: > > The dma related variable is dma_addr_t, it is uint64_t in > > x64 platform. Change these usage from uint32_to uint64_t to

Re: [Qemu-devel] [PATCH v2 3/3] edu: uses uint64_t in dma operation

2019-04-21 Thread Li Qiang
Philippe Mathieu-Daudé 于2019年4月21日周日 下午6:32写道: > On 4/20/19 6:14 PM, Li Qiang wrote: > > The dma related variable is dma_addr_t, it is uint64_t in > > x64 platform. Change these usage from uint32_to uint64_t to > > avoid trancation. > > "to avoid address truncation"? > > The dma.dst/src/cnt..is

Re: [Qemu-devel] [PATCH v2 3/3] edu: uses uint64_t in dma operation

2019-04-21 Thread Philippe Mathieu-Daudé
On 4/20/19 6:14 PM, Li Qiang wrote: > The dma related variable is dma_addr_t, it is uint64_t in > x64 platform. Change these usage from uint32_to uint64_t to > avoid trancation. "to avoid address truncation"? > > Signed-off-by: Li Qiang > --- > Change since v1: > Fix format compile error on Win

[Qemu-devel] [PATCH v2 3/3] edu: uses uint64_t in dma operation

2019-04-20 Thread Li Qiang
The dma related variable is dma_addr_t, it is uint64_t in x64 platform. Change these usage from uint32_to uint64_t to avoid trancation. Signed-off-by: Li Qiang --- Change since v1: Fix format compile error on Windows hw/misc/edu.c | 15 --- 1 file changed, 8 insertions(+), 7 deletio