Re: [Qemu-devel] [PATCH v2 3/3] dataplane: handle misaligned virtio-blk requests

2013-01-11 Thread Kevin Wolf
Am 11.01.2013 15:40, schrieb Stefan Hajnoczi: > On Fri, Jan 11, 2013 at 02:28:17PM +0100, Paolo Bonzini wrote: >> Il 11/01/2013 13:34, Stefan Hajnoczi ha scritto: >>> +iov = &bounce_iov; >>> +iov_cnt = 1; >>> + >>> +if (read) { >>> +/* Need to copy back from boun

Re: [Qemu-devel] [PATCH v2 3/3] dataplane: handle misaligned virtio-blk requests

2013-01-11 Thread Stefan Hajnoczi
On Fri, Jan 11, 2013 at 02:28:17PM +0100, Paolo Bonzini wrote: > Il 11/01/2013 13:34, Stefan Hajnoczi ha scritto: > > +iov = &bounce_iov; > > +iov_cnt = 1; > > + > > +if (read) { > > +/* Need to copy back from bounce buffer on completion */ > > +read_

Re: [Qemu-devel] [PATCH v2 3/3] dataplane: handle misaligned virtio-blk requests

2013-01-11 Thread Paolo Bonzini
Il 11/01/2013 13:34, Stefan Hajnoczi ha scritto: > +iov = &bounce_iov; > +iov_cnt = 1; > + > +if (read) { > +/* Need to copy back from bounce buffer on completion */ > +read_qiov = g_slice_new(QEMUIOVector); > +qemu_iovec_init(read_qiov, i

[Qemu-devel] [PATCH v2 3/3] dataplane: handle misaligned virtio-blk requests

2013-01-11 Thread Stefan Hajnoczi
O_DIRECT on Linux has alignment requirements on I/O buffers and misaligned requests result in -EINVAL. The Linux virtio_blk guest driver usually submits aligned requests so I forgot to handle misaligned requests. It turns out that virtio-win guest drivers submit misaligned requests. Handle them u