Re: [Qemu-devel] [PATCH v2 28/30] tests: add specialized device_find function

2017-03-01 Thread Marc-André Lureau
On Wed, Mar 1, 2017 at 3:22 AM Eric Blake wrote: > On 02/21/2017 08:14 AM, Marc-André Lureau wrote: > > Allows to specify which slot to look for the device. > > "Allow[s] to ${verb}" is not idiomatic; it's missing a subject. But > "Allows $subject to" (as in "allows someone to" or "allows me to"

Re: [Qemu-devel] [PATCH v2 28/30] tests: add specialized device_find function

2017-02-28 Thread Eric Blake
On 02/21/2017 08:14 AM, Marc-André Lureau wrote: > Allows to specify which slot to look for the device. "Allow[s] to ${verb}" is not idiomatic; it's missing a subject. But "Allows $subject to" (as in "allows someone to" or "allows me to") is wordy, compared to just saying "Allows ${verb}ing". I'

[Qemu-devel] [PATCH v2 28/30] tests: add specialized device_find function

2017-02-21 Thread Marc-André Lureau
Allows to specify which slot to look for the device. This will be used in the following patch to avoid leaking when multiple devices exists and we want to lookup the hotplug one. Signed-off-by: Marc-André Lureau --- tests/libqos/virtio-pci.h | 4 ++-- tests/libqos/virtio-pci.c | 31 +++