Re: [Qemu-devel] [PATCH v2 27/45] qmp: add drive-mirror command

2012-10-18 Thread Paolo Bonzini
Il 15/10/2012 19:33, Kevin Wolf ha scritto: > >> > +source = bs->backing_hd; >> > +if (!source && sync == MIRROR_SYNC_MODE_TOP) { >> > +sync = MIRROR_SYNC_MODE_FULL; >> > +} >> > + >> > +proto_drv = bdrv_find_protocol(target); >> > +if (!proto_drv) { >> > +error

Re: [Qemu-devel] [PATCH v2 27/45] qmp: add drive-mirror command

2012-10-15 Thread Paolo Bonzini
Il 15/10/2012 19:33, Kevin Wolf ha scritto: >> > + >> > +flags = bs->open_flags | BDRV_O_RDWR; > The two questions from last time are still open: > > Jeff's patches are in now, so we can do a bdrv_reopen() to remove > BDRV_O_RDWR again when completing the mirror job. It's not a big change, so

Re: [Qemu-devel] [PATCH v2 27/45] qmp: add drive-mirror command

2012-10-15 Thread Kevin Wolf
Am 26.09.2012 17:56, schrieb Paolo Bonzini: > This adds the monitor commands that start the mirroring job. > > Signed-off-by: Paolo Bonzini > --- > blockdev.c | 125 > ++- > hmp-commands.hx | 21 ++ > hmp.c| 28 +++

Re: [Qemu-devel] [PATCH v2 27/45] qmp: add drive-mirror command

2012-09-27 Thread Jeff Cody
On 09/26/2012 11:56 AM, Paolo Bonzini wrote: > This adds the monitor commands that start the mirroring job. > > Signed-off-by: Paolo Bonzini > --- > blockdev.c | 125 > ++- > hmp-commands.hx | 21 ++ > hmp.c| 28 ++

Re: [Qemu-devel] [PATCH v2 27/45] qmp: add drive-mirror command

2012-09-26 Thread Eric Blake
On 09/26/2012 09:56 AM, Paolo Bonzini wrote: > This adds the monitor commands that start the mirroring job. > > Signed-off-by: Paolo Bonzini > --- > blockdev.c | 125 > ++- > hmp-commands.hx | 21 ++ > hmp.c| 28 ++

[Qemu-devel] [PATCH v2 27/45] qmp: add drive-mirror command

2012-09-26 Thread Paolo Bonzini
This adds the monitor commands that start the mirroring job. Signed-off-by: Paolo Bonzini --- blockdev.c | 125 ++- hmp-commands.hx | 21 ++ hmp.c| 28 + hmp.h| 1 + qapi-schema.json | 33