Re: [Qemu-devel] [PATCH v2 26/45] ide/atapi: Preserve tray state on migration

2011-09-02 Thread Kevin Wolf
Am 02.09.2011 17:20, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 03.08.2011 15:08, schrieb Markus Armbruster: >>> Use a subsection, so that migration to older version still works, >>> provided the tray is closed and unlocked. >>> >>> Signed-off-by: Markus Armbruster >> >> Ah, here is

Re: [Qemu-devel] [PATCH v2 26/45] ide/atapi: Preserve tray state on migration

2011-09-02 Thread Paolo Bonzini
On 09/02/2011 05:22 PM, Markus Armbruster wrote: >> On another note, have our subsections been fixed meanwhile? If not, >> increasing the version number instead might be the right choice. Paolo? > > No, they haven't, but there's hope they will before 1.0. Use a subsection here anyway? Or sh

Re: [Qemu-devel] [PATCH v2 26/45] ide/atapi: Preserve tray state on migration

2011-09-02 Thread Markus Armbruster
Paolo Bonzini writes: > On 09/02/2011 02:20 PM, Kevin Wolf wrote: >> Ah, here is the migration part. The state wasn't migrated before, so not >> doing it in patch 10 doesn't break anything. I would still prefer to add >> migration in the same patch that adds the fields. >> >> You could just move

Re: [Qemu-devel] [PATCH v2 26/45] ide/atapi: Preserve tray state on migration

2011-09-02 Thread Markus Armbruster
Kevin Wolf writes: > Am 03.08.2011 15:08, schrieb Markus Armbruster: >> Use a subsection, so that migration to older version still works, >> provided the tray is closed and unlocked. >> >> Signed-off-by: Markus Armbruster > > Ah, here is the migration part. The state wasn't migrated before, so

Re: [Qemu-devel] [PATCH v2 26/45] ide/atapi: Preserve tray state on migration

2011-09-02 Thread Paolo Bonzini
On 09/02/2011 02:20 PM, Kevin Wolf wrote: Ah, here is the migration part. The state wasn't migrated before, so not doing it in patch 10 doesn't break anything. I would still prefer to add migration in the same patch that adds the fields. You could just move the subsection itself and keep the pos

Re: [Qemu-devel] [PATCH v2 26/45] ide/atapi: Preserve tray state on migration

2011-09-02 Thread Kevin Wolf
Am 03.08.2011 15:08, schrieb Markus Armbruster: > Use a subsection, so that migration to older version still works, > provided the tray is closed and unlocked. > > Signed-off-by: Markus Armbruster Ah, here is the migration part. The state wasn't migrated before, so not doing it in patch 10 doesn

[Qemu-devel] [PATCH v2 26/45] ide/atapi: Preserve tray state on migration

2011-08-03 Thread Markus Armbruster
Use a subsection, so that migration to older version still works, provided the tray is closed and unlocked. Signed-off-by: Markus Armbruster --- hw/ide/core.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c in