Re: [Qemu-devel] [PATCH v2 23/27] target/arm: Implement pauth_computepac

2019-01-07 Thread Richard Henderson
On 1/8/19 12:09 AM, Peter Maydell wrote: >> +static int rot_cell(int cell, int n) >> +{ >> +cell |= cell << 4; >> +cell >>= n; >> +return cell & 0xf; > > This doesn't seem to do what the RotCell pseudocode does? > Unless I've made an error, RotCell(ABCD, 1) == BCDA, > but rot_cell(ABCD

Re: [Qemu-devel] [PATCH v2 23/27] target/arm: Implement pauth_computepac

2019-01-07 Thread Peter Maydell
On Fri, 14 Dec 2018 at 05:24, Richard Henderson wrote: > > This is the main crypto routine, an implementation of QARMA. > This matches, as much as possible, ARM pseudocode. > > Signed-off-by: Richard Henderson > --- > target/arm/helper-a64.c | 241 +++- > 1 fi

[Qemu-devel] [PATCH v2 23/27] target/arm: Implement pauth_computepac

2018-12-13 Thread Richard Henderson
This is the main crypto routine, an implementation of QARMA. This matches, as much as possible, ARM pseudocode. Signed-off-by: Richard Henderson --- target/arm/helper-a64.c | 241 +++- 1 file changed, 240 insertions(+), 1 deletion(-) diff --git a/target/arm/h