Re: [Qemu-devel] [PATCH v2 2.1 2/3] blockjob: Fix recent BLOCK_JOB_ERROR regression

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 08:46, Markus Armbruster ha scritto: > I think consistency between BLOCK_IO_ERROR and BLOCK_JOB_ERROR is > better. Moreover, BlockdevOnError's enospc is meaningless here. > Let's fix the BlockErrorAction documentation instead. I didn't quite understand what's wrong with

Re: [Qemu-devel] [PATCH v2 2.1 2/3] blockjob: Fix recent BLOCK_JOB_ERROR regression

2014-07-01 Thread Markus Armbruster
Paolo Bonzini writes: > Il 01/07/2014 16:42, Wenchao Xia ha scritto: >>> diff --git a/qapi/block-core.json b/qapi/block-core.json >>> index 822fe16..fd5b579 100644 >>> --- a/qapi/block-core.json >>> +++ b/qapi/block-core.json >>> @@ -1544,7 +1544,7 @@ >>> { 'event': 'BLOCK_JOB_ERROR', >>> '

Re: [Qemu-devel] [PATCH v2 2.1 2/3] blockjob: Fix recent BLOCK_JOB_ERROR regression

2014-07-01 Thread Paolo Bonzini
Il 01/07/2014 16:42, Wenchao Xia ha scritto: >> diff --git a/qapi/block-core.json b/qapi/block-core.json >> index 822fe16..fd5b579 100644 >> --- a/qapi/block-core.json >> +++ b/qapi/block-core.json >> @@ -1544,7 +1544,7 @@ >> { 'event': 'BLOCK_JOB_ERROR', >> 'data': { 'device' : 'str', >>

Re: [Qemu-devel] [PATCH v2 2.1 2/3] blockjob: Fix recent BLOCK_JOB_ERROR regression

2014-07-01 Thread Wenchao Xia
于 2014/6/28 1:24, Markus Armbruster 写道: > Commit 5a2d2cb screwed up the the value of members device and action, > breaking tests/qemu-iotests/041. > > Signed-off-by: Markus Armbruster > Tested-By: Benoit Canet > Reviewed-by: Kevin Wolf > Reviewed-by: Luiz Capitulino > --- > blockjob.c

[Qemu-devel] [PATCH v2 2.1 2/3] blockjob: Fix recent BLOCK_JOB_ERROR regression

2014-06-27 Thread Markus Armbruster
Commit 5a2d2cb screwed up the the value of members device and action, breaking tests/qemu-iotests/041. Signed-off-by: Markus Armbruster Tested-By: Benoit Canet Reviewed-by: Kevin Wolf Reviewed-by: Luiz Capitulino --- blockjob.c | 2 +- qapi/block-core.json | 2 +- 2 files changed, 2