Re: [Qemu-devel] [PATCH v2 2/8] linux-user: arm: set CPSR.E correctly for BE8 mode

2014-05-30 Thread Peter Maydell
On 30 May 2014 07:46, Paolo Bonzini wrote: > Il 29/05/2014 22:38, Peter Maydell ha scritto: > >>> > +#ifdef TARGET_WORDS_BIGENDIAN >>> > +cpsr |= CPSR_E; >> >> This is wrong for BE32, where CPSR_E doesn't exist and both code >> and data accesses are big-endian. >> > > Is it okay for simplicity

Re: [Qemu-devel] [PATCH v2 2/8] linux-user: arm: set CPSR.E correctly for BE8 mode

2014-05-29 Thread Paolo Bonzini
Il 29/05/2014 22:38, Peter Maydell ha scritto: > +#ifdef TARGET_WORDS_BIGENDIAN > +cpsr |= CPSR_E; This is wrong for BE32, where CPSR_E doesn't exist and both code and data accesses are big-endian. Is it okay for simplicity to treat CPSR.E = 1 as "big-endian code, little-endian data" in

Re: [Qemu-devel] [PATCH v2 2/8] linux-user: arm: set CPSR.E correctly for BE8 mode

2014-05-29 Thread Peter Maydell
On 29 May 2014 20:46, Paolo Bonzini wrote: > Set it on startup and in signal handler frames. > > Signed-off-by: Paolo Bonzini > --- > linux-user/main.c | 1 + > linux-user/signal.c | 5 + > 2 files changed, 6 insertions(+) > > diff --git a/linux-user/main.c b/linux-user/main.c > index 8821

[Qemu-devel] [PATCH v2 2/8] linux-user: arm: set CPSR.E correctly for BE8 mode

2014-05-29 Thread Paolo Bonzini
Set it on startup and in signal handler frames. Signed-off-by: Paolo Bonzini --- linux-user/main.c | 1 + linux-user/signal.c | 5 + 2 files changed, 6 insertions(+) diff --git a/linux-user/main.c b/linux-user/main.c index 882186e..2a04446 100644 --- a/linux-user/main.c +++ b/linux-user/m