Re: [Qemu-devel] [PATCH v2 2/8] bitmap dump code via QAPI framework

2014-06-04 Thread Juan Quintela
Sanidhya Kashyap wrote: > Following are the changes made with respect to the previous version: > Chen's advice > 1) Replaced DIRTY_MEMORY_LOG_BITMAP with DIRTY_MEMORY_MIGRATION and > completely removed the DIRTY_MEMORY_LOG_BITMAP flag. > > Eric's advice > 2) Replaced FILE pointer with file descrip

Re: [Qemu-devel] [PATCH v2 2/8] bitmap dump code via QAPI framework

2014-06-04 Thread Dr. David Alan Gilbert
* Sanidhya Kashyap (sanidhya.ii...@gmail.com) wrote: > Following are the changes made with respect to the previous version: > Chen's advice > +if (qemu_write_full(fd, &ram_bitmap_pages, sizeof(int64_t)) < 0) { > +b->state = LOG_BITMAP_STATE_ERROR; > +goto log_thread_end; > +

[Qemu-devel] [PATCH v2 2/8] bitmap dump code via QAPI framework

2014-06-03 Thread Sanidhya Kashyap
Following are the changes made with respect to the previous version: Chen's advice 1) Replaced DIRTY_MEMORY_LOG_BITMAP with DIRTY_MEMORY_MIGRATION and completely removed the DIRTY_MEMORY_LOG_BITMAP flag. Eric's advice 2) Replaced FILE pointer with file descriptor. 3) Replaced fopen/fclose with qem