Re: [Qemu-devel] [PATCH v2 2/7] block: Add Error parameter to bdrv_amend_options

2018-05-09 Thread John Snow
On 05/09/2018 05:00 PM, Max Reitz wrote: > Looking at the qcow2 code that is riddled with error_report() calls, > this is really how it should have been from the start. > > Along the way, turn the target_version/current_version comparisons at > the beginning of qcow2_downgrade() into assertions

Re: [Qemu-devel] [PATCH v2 2/7] block: Add Error parameter to bdrv_amend_options

2018-05-09 Thread Eric Blake
On 05/09/2018 04:00 PM, Max Reitz wrote: Looking at the qcow2 code that is riddled with error_report() calls, this is really how it should have been from the start. Along the way, turn the target_version/current_version comparisons at the beginning of qcow2_downgrade() into assertions (the calle

[Qemu-devel] [PATCH v2 2/7] block: Add Error parameter to bdrv_amend_options

2018-05-09 Thread Max Reitz
Looking at the qcow2 code that is riddled with error_report() calls, this is really how it should have been from the start. Along the way, turn the target_version/current_version comparisons at the beginning of qcow2_downgrade() into assertions (the caller has to make sure these conditions are met