Re: [Qemu-devel] [PATCH v2 2/6] monitor: accept chardev input from iothread

2018-12-03 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Mon, Dec 3, 2018 at 11:26 AM Markus Armbruster wrote: >> >> Marc-André Lureau writes: >> >> > Chardev backends may not handle safely IO events from concurrent >> > threads. >> >> What exactly could go wrong? Or is this a well-known fact that doesn't >> nee

Re: [Qemu-devel] [PATCH v2 2/6] monitor: accept chardev input from iothread

2018-12-03 Thread Marc-André Lureau
Hi On Mon, Dec 3, 2018 at 11:26 AM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > Chardev backends may not handle safely IO events from concurrent > > threads. > > What exactly could go wrong? Or is this a well-known fact that doesn't > need further elaboration? chardev are not t

Re: [Qemu-devel] [PATCH v2 2/6] monitor: accept chardev input from iothread

2018-12-02 Thread Markus Armbruster
Marc-André Lureau writes: > Chardev backends may not handle safely IO events from concurrent > threads. What exactly could go wrong? Or is this a well-known fact that doesn't need further elaboration? "safely handle I/O events" > Better to wake up the chardev from the monitor IO thre

Re: [Qemu-devel] [PATCH v2 2/6] monitor: accept chardev input from iothread

2018-10-29 Thread Peter Xu
On Mon, Oct 29, 2018 at 04:57:29PM +0400, Marc-André Lureau wrote: > Chardev backends may not handle safely IO events from concurrent > threads. Better to wake up the chardev from the monitor IO thread if > it's being used as the chardev context. > > Unify code paths by using a BH in all cases. >

[Qemu-devel] [PATCH v2 2/6] monitor: accept chardev input from iothread

2018-10-29 Thread Marc-André Lureau
Chardev backends may not handle safely IO events from concurrent threads. Better to wake up the chardev from the monitor IO thread if it's being used as the chardev context. Unify code paths by using a BH in all cases. Drop the now redundant aio_notify() call. Signed-off-by: Marc-André Lureau -