Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock

2012-01-30 Thread Paolo Bonzini
On 01/30/2012 08:28 PM, Anthony Liguori wrote: I see. It shouldn't surprise you that I completely disagree with Anthony on this. :) Give me some credit at least... The original patches didn't disable the RTC, it introduced a half-neutered Xen specific RTC. Ah. :) My original suggestion (w

Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock

2012-01-30 Thread Anthony Liguori
On 01/30/2012 05:59 AM, Paolo Bonzini wrote: On 01/30/2012 12:56 PM, Stefano Stabellini wrote: > Depending on "-rtc clock=vm" or "-rtc clock=rt", this may not be true. Good point. I should check for rtc_clock == host_clock. > Why do you need to instantiate an RTC at all? I don't, in fact in

Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock

2012-01-30 Thread Stefano Stabellini
On Mon, 30 Jan 2012, Paolo Bonzini wrote: > On 01/30/2012 12:56 PM, Stefano Stabellini wrote: > >> > Depending on "-rtc clock=vm" or "-rtc clock=rt", this may not be true. > > > > Good point. > > I should check for rtc_clock == host_clock. > > > >> > Why do you need to instantiate an RTC at all?

Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock

2012-01-30 Thread Paolo Bonzini
On 01/30/2012 12:56 PM, Stefano Stabellini wrote: > Depending on "-rtc clock=vm" or "-rtc clock=rt", this may not be true. Good point. I should check for rtc_clock == host_clock. > Why do you need to instantiate an RTC at all? I don't, in fact in previous versions of this patch series I tr

Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock

2012-01-30 Thread Stefano Stabellini
On Fri, 27 Jan 2012, Paolo Bonzini wrote: > On 01/27/2012 01:26 PM, Stefano Stabellini wrote: > > rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen > > has its own RTC emulator in the hypervisor so we can disable it. > > > > Signed-off-by: Stefano Stabellini > > --- > > xen-

Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock

2012-01-27 Thread Paolo Bonzini
On 01/27/2012 01:26 PM, Stefano Stabellini wrote: rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen has its own RTC emulator in the hypervisor so we can disable it. Signed-off-by: Stefano Stabellini --- xen-all.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock

2012-01-27 Thread Stefano Stabellini
rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen has its own RTC emulator in the hypervisor so we can disable it. Signed-off-by: Stefano Stabellini --- xen-all.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index d1fc597..b