Re: [Qemu-devel] [PATCH v2 2/5] target-i386: Add Intel HAX files

2016-11-14 Thread Vincent Palatin
On Mon, Nov 14, 2016 at 11:15 AM, Paolo Bonzini wrote: > > > On 11/11/2016 12:28, Vincent Palatin wrote: >> + >> +memcpy(env->xmm_regs, fpu.mmx_1, sizeof(fpu.mmx_1)); >> +memcpy((ZMMReg *) (env->xmm_regs) + 8, fpu.mmx_2, sizeof(fpu.mmx_2)); > > HAX will only support SSE (128-bit) registers

Re: [Qemu-devel] [PATCH v2 2/5] target-i386: Add Intel HAX files

2016-11-14 Thread Paolo Bonzini
On 11/11/2016 12:28, Vincent Palatin wrote: > + > +memcpy(env->xmm_regs, fpu.mmx_1, sizeof(fpu.mmx_1)); > +memcpy((ZMMReg *) (env->xmm_regs) + 8, fpu.mmx_2, sizeof(fpu.mmx_2)); HAX will only support SSE (128-bit) registers, while env->xmm_regs supports AVX512 (512-bit) so you have to cop

Re: [Qemu-devel] [PATCH v2 2/5] target-i386: Add Intel HAX files

2016-11-14 Thread Paolo Bonzini
On 11/11/2016 12:28, Vincent Palatin wrote: > + > +memcpy(env->xmm_regs, fpu.mmx_1, sizeof(fpu.mmx_1)); > +memcpy((ZMMReg *) (env->xmm_regs) + 8, fpu.mmx_2, sizeof(fpu.mmx_2)); HAX will only support SSE (128-bit) registers, while env->xmm_regs supports AVX512 (512-bit) so you have to cop

Re: [Qemu-devel] [PATCH v2 2/5] target-i386: Add Intel HAX files

2016-11-14 Thread Vincent Palatin
On Mon, Nov 14, 2016 at 10:29 AM, Stefan Weil wrote: > Am 11.11.2016 um 12:28 schrieb Vincent Palatin: > [...] >> >> Signed-off-by: Vincent Palatin >> --- >> hax-stub.c | 74 +++ >> include/sysemu/hax.h| 66 ++ >> target-i386/hax-all.c | 1490 >> ++

Re: [Qemu-devel] [PATCH v2 2/5] target-i386: Add Intel HAX files

2016-11-14 Thread Stefan Weil
Am 11.11.2016 um 12:28 schrieb Vincent Palatin: [...] > > Signed-off-by: Vincent Palatin > --- > hax-stub.c | 74 +++ > include/sysemu/hax.h| 66 ++ > target-i386/hax-all.c | 1490 > +++ Git warns about a whitespace issu

[Qemu-devel] [PATCH v2 2/5] target-i386: Add Intel HAX files

2016-11-11 Thread Vincent Palatin
That's a forward port of the core HAX interface code mostly unmodified from emu-2.2-release branch in the external/qemu-android repository as used by the Android emulator. The original commit was "target-i386: Add Intel HAX to android emulator" saying: """ Backport of 2b3098ff27bab079caab9b46b58