Re: [Qemu-devel] [PATCH v2 2/4] qapi: Drop duplicate c_fun() in favor of c_var()

2015-05-01 Thread Eric Blake
On 04/29/2015 05:04 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Now that the two functions are identical, we only need one of them. >> >> Signed-off-by: Eric Blake > > c_var() isn't the possible best name, but it'll do. I'm looking at using c_name() in my v3. -- Eric Blake eblak

Re: [Qemu-devel] [PATCH v2 2/4] qapi: Drop duplicate c_fun() in favor of c_var()

2015-04-29 Thread Markus Armbruster
Eric Blake writes: > Now that the two functions are identical, we only need one of them. > > Signed-off-by: Eric Blake c_var() isn't the possible best name, but it'll do. Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 2/4] qapi: Drop duplicate c_fun() in favor of c_var()

2015-04-15 Thread Alberto Garcia
On Sáb 11 Abr 2015 20:09:41 CEST, Eric Blake wrote: > Now that the two functions are identical, we only need one of them. > > Signed-off-by: Eric Blake > --- > scripts/qapi-commands.py | 15 --- > scripts/qapi-event.py| 2 +- > scripts/qapi-types.py| 4 ++-- > scripts/qapi-v

[Qemu-devel] [PATCH v2 2/4] qapi: Drop duplicate c_fun() in favor of c_var()

2015-04-11 Thread Eric Blake
Now that the two functions are identical, we only need one of them. Signed-off-by: Eric Blake --- scripts/qapi-commands.py | 15 --- scripts/qapi-event.py| 2 +- scripts/qapi-types.py| 4 ++-- scripts/qapi-visit.py| 4 ++-- scripts/qapi.py | 5 + 5 files