Re: [Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.

2013-05-05 Thread Jean-Christophe DUBOIS
On 05/05/2013 01:34 PM, Andreas Färber wrote: Am 05.05.2013 05:14, schrieb Peter Crosthwaite: On Sun, May 5, 2013 at 12:09 AM, Jean-Christophe DUBOIS wrote: diff --git a/hw/i2c/imx_i2c.c b/hw/i2c/imx_i2c.c new file mode 100644 index 000..5b0d046 --- /dev/null +++ b/hw/i2c/imx_i2c.c [...]

Re: [Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.

2013-05-05 Thread Jean-Christophe DUBOIS
On 05/05/2013 01:53 PM, Peter Crosthwaite wrote: Hi Peter, On Sun, May 5, 2013 at 9:41 PM, Peter Maydell wrote: On 5 May 2013 11:53, Peter Crosthwaite wrote: On Sun, May 5, 2013 at 8:47 PM, Peter Maydell wrote: On 5 May 2013 04:58, Jean-Christophe DUBOIS wrote: no extract16() macro spott

Re: [Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.

2013-05-05 Thread Peter Crosthwaite
Hi Peter, On Sun, May 5, 2013 at 9:41 PM, Peter Maydell wrote: > On 5 May 2013 11:53, Peter Crosthwaite wrote: >> On Sun, May 5, 2013 at 8:47 PM, Peter Maydell >> wrote: >>> On 5 May 2013 04:58, Jean-Christophe DUBOIS wrote: no extract16() macro spotted. Should one be added? >>> >>>

Re: [Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.

2013-05-05 Thread Peter Maydell
On 5 May 2013 11:53, Peter Crosthwaite wrote: > On Sun, May 5, 2013 at 8:47 PM, Peter Maydell > wrote: >> On 5 May 2013 04:58, Jean-Christophe DUBOIS wrote: >>> no extract16() macro spotted. >>> Should one be added? >> >> There's no need for one -- just use extract32. The only >> reason for hav

Re: [Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.

2013-05-05 Thread Andreas Färber
Am 05.05.2013 05:14, schrieb Peter Crosthwaite: > On Sun, May 5, 2013 at 12:09 AM, Jean-Christophe DUBOIS > wrote: >> diff --git a/hw/i2c/imx_i2c.c b/hw/i2c/imx_i2c.c >> new file mode 100644 >> index 000..5b0d046 >> --- /dev/null >> +++ b/hw/i2c/imx_i2c.c [...] >> +typedef struct imx_i2c_state

Re: [Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.

2013-05-05 Thread Peter Crosthwaite
Hi Peter, On Sun, May 5, 2013 at 8:47 PM, Peter Maydell wrote: > On 5 May 2013 04:58, Jean-Christophe DUBOIS wrote: >> On 05/05/2013 05:14 AM, Peter Crosthwaite wrote: >>> You could use an extract macro. extract32 is generally considered >>> better than shift and & logicvfor multi-bit fields. Il

Re: [Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.

2013-05-05 Thread Peter Maydell
On 5 May 2013 04:58, Jean-Christophe DUBOIS wrote: > On 05/05/2013 05:14 AM, Peter Crosthwaite wrote: >> You could use an extract macro. extract32 is generally considered >> better than shift and & logicvfor multi-bit fields. Ill have to look >> up if extract16 exists (im away from tree for this r

Re: [Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.

2013-05-04 Thread Jean-Christophe DUBOIS
On 05/05/2013 05:14 AM, Peter Crosthwaite wrote: Hi JC, Thanks for actioning the comments. On Sun, May 5, 2013 at 12:09 AM, Jean-Christophe DUBOIS wrote: The slave mode is not implemented. Signed-off-by: Jean-Christophe DUBOIS --- As a general rule you need to indicate changes between the

Re: [Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.

2013-05-04 Thread Peter Crosthwaite
Hi JC, Thanks for actioning the comments. On Sun, May 5, 2013 at 12:09 AM, Jean-Christophe DUBOIS wrote: > The slave mode is not implemented. > > Signed-off-by: Jean-Christophe DUBOIS > --- As a general rule you need to indicate changes between the last version and this version (changlog). My

[Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.

2013-05-04 Thread Jean-Christophe DUBOIS
The slave mode is not implemented. Signed-off-by: Jean-Christophe DUBOIS --- default-configs/arm-softmmu.mak | 2 + hw/i2c/Makefile.objs| 1 + hw/i2c/imx_i2c.c| 383 include/hw/arm/imx.h| 1 + 4 files changed,