Re: [Qemu-devel] [PATCH v2 2/3] virtio-mmio: introduce set_guest_notifiers

2015-05-08 Thread Cornelia Huck
On Fri, 08 May 2015 13:30:18 +0300 Pavel Fedin wrote: > Hello! > > > Yes, I think it makes sense to just pick the low-hanging fruit for > > virtio-mmio and wait for pci. > > Does this mean that my series can be accepted as it is? Since PCI is > potentially better > solution, MMIO is a low pr

Re: [Qemu-devel] [PATCH v2 2/3] virtio-mmio: introduce set_guest_notifiers

2015-05-08 Thread Pavel Fedin
> To: Pavel Fedin > Cc: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH v2 2/3] virtio-mmio: introduce > set_guest_notifiers > > On Fri, 08 May 2015 09:45:00 +0300 > Pavel Fedin wrote: > > > Hello! > > > > > Hm, weren't there some

Re: [Qemu-devel] [PATCH v2 2/3] virtio-mmio: introduce set_guest_notifiers

2015-05-08 Thread Cornelia Huck
On Fri, 08 May 2015 09:45:00 +0300 Pavel Fedin wrote: > Hello! > > > Hm, weren't there some patches for irqfd on arm? > > Yes, there were. However, they had a design problem by breaking backwards > compatibility > with unmodified virtio. Their idea was to set up one more shared memory area

Re: [Qemu-devel] [PATCH v2 2/3] virtio-mmio: introduce set_guest_notifiers

2015-05-07 Thread Pavel Fedin
Hello! > Hm, weren't there some patches for irqfd on arm? Yes, there were. However, they had a design problem by breaking backwards compatibility with unmodified virtio. Their idea was to set up one more shared memory area between virtio and vhost-net and use it to pass ISR value, which helps

Re: [Qemu-devel] [PATCH v2 2/3] virtio-mmio: introduce set_guest_notifiers

2015-05-07 Thread Cornelia Huck
On Thu, 07 May 2015 13:49:54 +0300 Pavel Fedin wrote: > Same as host notifier of virtio-mmio, most of codes came from virtio-pci. Possibly another case for common helper functions, as I also copied a lot of stuff from pci for ccw :) > The kvm-arm does not yet support irqfd, need to fix the hard

[Qemu-devel] [PATCH v2 2/3] virtio-mmio: introduce set_guest_notifiers

2015-05-07 Thread Pavel Fedin
Same as host notifier of virtio-mmio, most of codes came from virtio-pci. The kvm-arm does not yet support irqfd, need to fix the hard-coded part after kvm-arm gets irqfd support. Signed-off-by: Ying-Shiuan Pan Signed-off-by: Pavel Fedin --- hw/virtio/virtio-mmio.c | 61