Re: [Qemu-devel] [PATCH v2 2/3] hda-codec: make mixemu selectable at runtime

2013-09-06 Thread Bandan Das
Gerd Hoffmann writes: >> --- a/hw/audio/hda-codec.c >> +++ b/hw/audio/hda-codec.c >> @@ -118,7 +118,20 @@ static void hda_codec_parse_fmt(uint32_t format, struct >> audsettings *as) >> #define QEMU_HDA_AMP_NONE(0) >> #define QEMU_HDA_AMP_STEPS 0x4a >> >> +#ifdef CONFIG_MIXEMU >> +#defi

Re: [Qemu-devel] [PATCH v2 2/3] hda-codec: make mixemu selectable at runtime

2013-09-06 Thread Gerd Hoffmann
> --- a/hw/audio/hda-codec.c > +++ b/hw/audio/hda-codec.c > @@ -118,7 +118,20 @@ static void hda_codec_parse_fmt(uint32_t format, struct > audsettings *as) > #define QEMU_HDA_AMP_NONE(0) > #define QEMU_HDA_AMP_STEPS 0x4a > > +#ifdef CONFIG_MIXEMU > +#define PARAM mixemu > +#define HD

[Qemu-devel] [PATCH v2 2/3] hda-codec: make mixemu selectable at runtime

2013-09-05 Thread Bandan Das
Define PARAM so that we have two versions of the "desc_codec and family" structs. Add a property called "mixer" whose default value depends on whether CONFIG_MIXEMU is defined or not which will help us call the appropriate instance init functions. Signed-off-by: Bandan Das --- hw/audio/hda-code