Re: [Qemu-devel] [PATCH v2 2/3] arm: qmp: add query-gic-capability interface

2016-03-03 Thread Peter Xu
On Thu, Mar 03, 2016 at 12:55:51PM +0100, Andrew Jones wrote: > On Thu, Mar 03, 2016 at 04:21:11PM +0800, Peter Xu wrote: > > + > > +GICCapabilityList *qmp_query_gic_capability(Error **errp); > > I don't know anything about QMP, so just offering a superficial > review comment. Is the prototype nec

Re: [Qemu-devel] [PATCH v2 2/3] arm: qmp: add query-gic-capability interface

2016-03-03 Thread Andrew Jones
On Thu, Mar 03, 2016 at 04:21:11PM +0800, Peter Xu wrote: > This implement the command "query-gic-capability" but not implemnet > it. The command is ARM-only. Return of the command is a list of > GICCapability struct that describes all GIC versions that current > QEMU and system support. > > Signe

[Qemu-devel] [PATCH v2 2/3] arm: qmp: add query-gic-capability interface

2016-03-03 Thread Peter Xu
This implement the command "query-gic-capability" but not implemnet it. The command is ARM-only. Return of the command is a list of GICCapability struct that describes all GIC versions that current QEMU and system support. Signed-off-by: Peter Xu --- monitor.c| 8 qapi-sche