Re: [Qemu-devel] [PATCH v2 2/2] spapr_pci: make index property mandatory

2017-09-19 Thread David Gibson
On Tue, Sep 19, 2017 at 04:03:57PM +0200, Greg Kurz wrote: > On Tue, 19 Sep 2017 09:03:58 +1000 > David Gibson wrote: > > > On Thu, Sep 14, 2017 at 04:14:44PM +0200, Greg Kurz wrote: > > > Creating several PHBs without index property confuses the DRC code > > > and causes issues: > > > - only the

Re: [Qemu-devel] [PATCH v2 2/2] spapr_pci: make index property mandatory

2017-09-19 Thread Greg Kurz
On Tue, 19 Sep 2017 09:03:58 +1000 David Gibson wrote: > On Thu, Sep 14, 2017 at 04:14:44PM +0200, Greg Kurz wrote: > > Creating several PHBs without index property confuses the DRC code > > and causes issues: > > - only the first index-less PHB is functional, the other ones will > > silently i

Re: [Qemu-devel] [PATCH v2 2/2] spapr_pci: make index property mandatory

2017-09-19 Thread David Gibson
On Thu, Sep 14, 2017 at 04:14:44PM +0200, Greg Kurz wrote: > Creating several PHBs without index property confuses the DRC code > and causes issues: > - only the first index-less PHB is functional, the other ones will > silently ignore hotplugging of PCI devices > - QEMU will even terminate if th

[Qemu-devel] [PATCH v2 2/2] spapr_pci: make index property mandatory

2017-09-14 Thread Greg Kurz
Creating several PHBs without index property confuses the DRC code and causes issues: - only the first index-less PHB is functional, the other ones will silently ignore hotplugging of PCI devices - QEMU will even terminate if these PHBs have cold-plugged devices qemu-system-ppc64: -device virtio