Re: [Qemu-devel] [PATCH v2 2/2] ipmi: Add a UUID device property

2019-07-06 Thread Corey Minyard
On Wed, Jul 03, 2019 at 03:26:25PM +0100, Daniel P. Berrangé wrote: > On Mon, Jul 01, 2019 at 01:31:00PM -0500, miny...@acm.org wrote: > > From: Corey Minyard > > > > Using the UUID that qemu generates probably isn't the best thing > > to do, allow it to be passed in via properties, and use QemuU

Re: [Qemu-devel] [PATCH v2 2/2] ipmi: Add a UUID device property

2019-07-03 Thread Daniel P . Berrangé
On Mon, Jul 01, 2019 at 01:31:00PM -0500, miny...@acm.org wrote: > From: Corey Minyard > > Using the UUID that qemu generates probably isn't the best thing > to do, allow it to be passed in via properties, and use QemuUUID > for the type. AFAICT, QEMU isn't generating a UUID in the current code.

Re: [Qemu-devel] [PATCH v2 2/2] ipmi: Add a UUID device property

2019-07-02 Thread Philippe Mathieu-Daudé
On 7/1/19 8:31 PM, miny...@acm.org wrote: > From: Corey Minyard > > Using the UUID that qemu generates probably isn't the best thing > to do, allow it to be passed in via properties, and use QemuUUID > for the type. > > If the UUID is not set, return an unsupported command error. This > way we

[Qemu-devel] [PATCH v2 2/2] ipmi: Add a UUID device property

2019-07-01 Thread minyard
From: Corey Minyard Using the UUID that qemu generates probably isn't the best thing to do, allow it to be passed in via properties, and use QemuUUID for the type. If the UUID is not set, return an unsupported command error. This way we are not providing an all-zero (or randomly generated) GUID