Re: [Qemu-devel] [PATCH v2 2/2] doc: Introduce coding style for errors

2015-11-24 Thread Markus Armbruster
Lluís Vilanova writes: > Markus Armbruster writes: > >> "Daniel P. Berrange" writes: >>> On Mon, Nov 23, 2015 at 07:41:24PM +0100, Lluís Vilanova wrote: Gives some general guidelines for reporting errors in QEMU. Signed-off-by: Lluís Vilanova --- HACKING | 31 +++

Re: [Qemu-devel] [PATCH v2 2/2] doc: Introduce coding style for errors

2015-11-24 Thread Lluís Vilanova
Markus Armbruster writes: > "Daniel P. Berrange" writes: >> On Mon, Nov 23, 2015 at 07:41:24PM +0100, Lluís Vilanova wrote: >>> Gives some general guidelines for reporting errors in QEMU. >>> >>> Signed-off-by: Lluís Vilanova >>> --- >>> HACKING | 31 +++ >>> 1 file

Re: [Qemu-devel] [PATCH v2 2/2] doc: Introduce coding style for errors

2015-11-23 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Mon, Nov 23, 2015 at 09:05:30PM +0100, Lluís Vilanova wrote: >> Daniel P Berrange writes: >> [...] >> > I don't think this "Errors in user inputs" vs "Other errors" distinction >> > really makes sense. Whether an error raised in a piece of code is related >> > to

Re: [Qemu-devel] [PATCH v2 2/2] doc: Introduce coding style for errors

2015-11-23 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Mon, Nov 23, 2015 at 07:41:24PM +0100, Lluís Vilanova wrote: >> Gives some general guidelines for reporting errors in QEMU. >> >> Signed-off-by: Lluís Vilanova >> --- >> HACKING | 31 +++ >> 1 file changed, 31 insertions(+) >> >>

Re: [Qemu-devel] [PATCH v2 2/2] doc: Introduce coding style for errors

2015-11-23 Thread Daniel P. Berrange
On Mon, Nov 23, 2015 at 09:05:30PM +0100, Lluís Vilanova wrote: > Daniel P Berrange writes: > [...] > > I don't think this "Errors in user inputs" vs "Other errors" distinction > > really makes sense. Whether an error raised in a piece of code is related > > to user input or not is almost impossibl

Re: [Qemu-devel] [PATCH v2 2/2] doc: Introduce coding style for errors

2015-11-23 Thread Lluís Vilanova
Daniel P Berrange writes: [...] > I don't think this "Errors in user inputs" vs "Other errors" distinction > really makes sense. Whether an error raised in a piece of code is related > to user input or not is almost impossible to determine in practice. So as > a rule to follow it is not practical.

Re: [Qemu-devel] [PATCH v2 2/2] doc: Introduce coding style for errors

2015-11-23 Thread Daniel P. Berrange
On Mon, Nov 23, 2015 at 07:41:24PM +0100, Lluís Vilanova wrote: > Gives some general guidelines for reporting errors in QEMU. > > Signed-off-by: Lluís Vilanova > --- > HACKING | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git a/HACKING b/HACKING > index 1

[Qemu-devel] [PATCH v2 2/2] doc: Introduce coding style for errors

2015-11-23 Thread Lluís Vilanova
Gives some general guidelines for reporting errors in QEMU. Signed-off-by: Lluís Vilanova --- HACKING | 31 +++ 1 file changed, 31 insertions(+) diff --git a/HACKING b/HACKING index 12fbc8a..e59bc34 100644 --- a/HACKING +++ b/HACKING @@ -157,3 +157,34 @@ painful. T