Re: [Qemu-devel] [PATCH v2 19/68] target/arm: Convert T32 ADDW/SUBW

2019-08-23 Thread Richard Henderson
On 8/23/19 7:47 AM, Peter Maydell wrote: > On Fri, 23 Aug 2019 at 15:45, Richard Henderson > wrote: >> >> On 8/23/19 6:04 AM, Peter Maydell wrote: +&ri rd imm &r rm &i imm &msr_reg rn r mask >>> >>> Should this change be in so

Re: [Qemu-devel] [PATCH v2 19/68] target/arm: Convert T32 ADDW/SUBW

2019-08-23 Thread Richard Henderson
On 8/23/19 6:04 AM, Peter Maydell wrote: >> +static bool trans_ADR(DisasContext *s, arg_ri *a) >> +{ >> +store_reg_bx(s, a->rd, add_reg_for_lit(s, 15, a->imm)); >> +return true; >> +} ... >> -if (rn == 13 && rd == 13) { >> -/* ADD SP, SP,

Re: [Qemu-devel] [PATCH v2 19/68] target/arm: Convert T32 ADDW/SUBW

2019-08-23 Thread Peter Maydell
On Fri, 23 Aug 2019 at 15:45, Richard Henderson wrote: > > On 8/23/19 6:04 AM, Peter Maydell wrote: > >> +&ri rd imm > >> &r rm > >> &i imm > >> &msr_reg rn r mask > > > > Should this change be in some other patch ? > > No, it's used by ADR. > >

Re: [Qemu-devel] [PATCH v2 19/68] target/arm: Convert T32 ADDW/SUBW

2019-08-23 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 24 +--- > target/arm/a32.decode | 1 + > target/arm/t32.decode | 19 +++ > 3 files changed, 33 insertions(+), 11 deletions(-) > > d

[Qemu-devel] [PATCH v2 19/68] target/arm: Convert T32 ADDW/SUBW

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 24 +--- target/arm/a32.decode | 1 + target/arm/t32.decode | 19 +++ 3 files changed, 33 insertions(+), 11 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index cb6296d