Re: [Qemu-devel] [PATCH v2 19/41] char: remove class kind field

2017-01-31 Thread Paolo Bonzini
On 31/01/2017 04:08, Marc-André Lureau wrote: > Hi > > On Tue, Jan 31, 2017 at 12:08 AM Paolo Bonzini > wrote: > > > > On 30/01/2017 08:39, Marc-André Lureau wrote: > > The class kind is necessary to lookup the chardev name in > > qmp_chardev_add() aft

Re: [Qemu-devel] [PATCH v2 19/41] char: remove class kind field

2017-01-31 Thread Paolo Bonzini
On 31/01/2017 06:23, Marc-André Lureau wrote: > > Unless I missed something and you object, are you ok for me to send the > pull request for this series? thanks Yes, go ahead. Paolo

Re: [Qemu-devel] [PATCH v2 19/41] char: remove class kind field

2017-01-31 Thread Marc-André Lureau
Hi On Tue, Jan 31, 2017 at 1:08 PM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Tue, Jan 31, 2017 at 12:08 AM Paolo Bonzini > wrote: > > > > On 30/01/2017 08:39, Marc-André Lureau wrote: > > The class kind is necessary to lookup the chardev name in > > qmp_chardev_add() aft

Re: [Qemu-devel] [PATCH v2 19/41] char: remove class kind field

2017-01-31 Thread Marc-André Lureau
Hi On Tue, Jan 31, 2017 at 12:08 AM Paolo Bonzini wrote: > > > On 30/01/2017 08:39, Marc-André Lureau wrote: > > The class kind is necessary to lookup the chardev name in > > qmp_chardev_add() after calling qemu_chr_new_from_opts() and to set > > the appropriate ChardevBackend (mainly to free th

Re: [Qemu-devel] [PATCH v2 19/41] char: remove class kind field

2017-01-30 Thread Paolo Bonzini
On 30/01/2017 08:39, Marc-André Lureau wrote: > The class kind is necessary to lookup the chardev name in > qmp_chardev_add() after calling qemu_chr_new_from_opts() and to set > the appropriate ChardevBackend (mainly to free the right > fields). > > qemu_chr_new_from_opts() can be changed to use

Re: [Qemu-devel] [PATCH v2 19/41] char: remove class kind field

2017-01-30 Thread Eric Blake
On 01/30/2017 07:39 AM, Marc-André Lureau wrote: > The class kind is necessary to lookup the chardev name in > qmp_chardev_add() after calling qemu_chr_new_from_opts() and to set > the appropriate ChardevBackend (mainly to free the right > fields). > > qemu_chr_new_from_opts() can be changed to us

[Qemu-devel] [PATCH v2 19/41] char: remove class kind field

2017-01-30 Thread Marc-André Lureau
The class kind is necessary to lookup the chardev name in qmp_chardev_add() after calling qemu_chr_new_from_opts() and to set the appropriate ChardevBackend (mainly to free the right fields). qemu_chr_new_from_opts() can be changed to use a non-qmp function using the chardev class typename. Introd