Re: [Qemu-devel] [PATCH v2 16/17] target/riscv: convert to DisasContextBase

2018-04-13 Thread Richard Henderson
On 04/06/2018 08:19 AM, Emilio G. Cota wrote: > Notes: > > - Did not convert {num,max}_insns, since the corresponding code > will go away in the next patch. > > - ctx->pc becomes ctx->base.pc_next, and ctx->next_pc becomes ctx->pc_tmp. > > While at it, convert the remaining tb->cflags readers

Re: [Qemu-devel] [PATCH v2 16/17] target/riscv: convert to DisasContextBase

2018-04-09 Thread Emilio G. Cota
On Mon, Apr 09, 2018 at 16:22:53 +0200, Bastian Koppelmann wrote: > On 04/06/2018 08:19 PM, Emilio G. Cota wrote: > > Notes: > > > > - Did not convert {num,max}_insns, since the corresponding code > > will go away in the next patch. > > > > - ctx->pc becomes ctx->base.pc_next, and ctx->next_pc

Re: [Qemu-devel] [PATCH v2 16/17] target/riscv: convert to DisasContextBase

2018-04-09 Thread Bastian Koppelmann
On 04/06/2018 08:19 PM, Emilio G. Cota wrote: > Notes: > > - Did not convert {num,max}_insns, since the corresponding code > will go away in the next patch. > > - ctx->pc becomes ctx->base.pc_next, and ctx->next_pc becomes ctx->pc_tmp. Please call pc_tmp something meaningful, like pc_succ_insn

[Qemu-devel] [PATCH v2 16/17] target/riscv: convert to DisasContextBase

2018-04-06 Thread Emilio G. Cota
Notes: - Did not convert {num,max}_insns, since the corresponding code will go away in the next patch. - ctx->pc becomes ctx->base.pc_next, and ctx->next_pc becomes ctx->pc_tmp. While at it, convert the remaining tb->cflags readers to tb_cflags(). Cc: Michael Clark Cc: Palmer Dabbelt Cc: Sa